Re: [PATCH v2 2/2] net: Drop the NetLegacy structure, always use Netdev instead

[Eric Blake]

On 5/12/20 10:13 AM, Thomas Huth wrote:

> > > +++ b/qapi/net.json
> > > @@ -453,7 +453,7 @@
> > >    #        'l2tpv3' - since 2.1
> > >    ##
> > >    { 'union': 'Netdev',
> > > -  'base': { 'id': 'str', 'type': 'NetClientDriver' },
> > > +  'base': { '*id': 'str', 'type': 'NetClientDriver' },
> >
> > I don't think we need to make 'id' optional.
>
> It's required for "-net" now.

But does -net generate it's own id if one is not provided?  Can it still 
be mandatory in the QAPI type, and just figure out how to guarantee that 
the CLI parsing of -net provides a name early enough in the cycle to use 
the QAPI type without making the member optional there?

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org