Re: [PATCH v8 02/74] cpu: rename cpu->work_mutex to cpu->lock

[Robert Foley]

On Mon, 11 May 2020 at 10:48, Alex Bennée <address@hidden> wrote:
> Hmm while bisecting to find another problem I found this commit:
>
>   /home/alex/lsrc/qemu.git/hw/core/cpu.c: In function ‘cpu_common_finalize’:
>   /home/alex/lsrc/qemu.git/hw/core/cpu.c:383:27: error: incompatible type for 
> argument 1 of ‘qemu_mutex_destroy’
>        qemu_mutex_destroy(cpu->lock);
>                           ~~~^~~~~~
>   In file included from /home/alex/lsrc/qemu.git/include/hw/core/cpu.h:31,
>                    from /home/alex/lsrc/qemu.git/hw/core/cpu.c:23:
>   /home/alex/lsrc/qemu.git/include/qemu/thread.h:26:36: note: expected 
> ‘QemuMutex *’ {aka ‘struct QemuMutex *’} but argument is of type ‘QemuMutex’ 
> {aka ‘struct QemuMutex’}
>    void qemu_mutex_destroy(QemuMutex *mutex);
>                            ~~~~~~~~~~~^~~~~
>   make: *** [/home/alex/lsrc/qemu.git/rules.mak:69: hw/core/cpu.o] Error 1
>
> which works fine in the final product so I suspect something has slipped
> between commits somewhere.

I agree, looks like something is off with the intermediate commits.
Thanks for noticing it !  Will fix it.

Thanks,
-Rob