[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 11/34] accel/tcg: Adjust probe_access call to page_check_range
From: |
Peter Maydell |
Subject: |
[PULL 11/34] accel/tcg: Adjust probe_access call to page_check_range |
Date: |
Mon, 11 May 2020 14:33:42 +0100 |
From: Richard Henderson <address@hidden>
We have validated that addr+size does not cross a page boundary.
Therefore we need to validate exactly one page. We can achieve
that passing any value 1 <= x <= size to page_check_range.
Passing 1 will simplify the next patch.
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
---
accel/tcg/user-exec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c
index 4be78eb9b38..03538e2a389 100644
--- a/accel/tcg/user-exec.c
+++ b/accel/tcg/user-exec.c
@@ -211,7 +211,7 @@ void *probe_access(CPUArchState *env, target_ulong addr,
int size,
g_assert_not_reached();
}
- if (!guest_addr_valid(addr) || page_check_range(addr, size, flags) < 0) {
+ if (!guest_addr_valid(addr) || page_check_range(addr, 1, flags) < 0) {
CPUState *cpu = env_cpu(env);
CPUClass *cc = CPU_GET_CLASS(cpu);
cc->tlb_fill(cpu, addr, size, access_type, MMU_USER_IDX, false,
--
2.20.1
- [PULL 00/34] target-arm queue, Peter Maydell, 2020/05/11
- [PULL 01/34] aspeed: Add boot stub for smp booting, Peter Maydell, 2020/05/11
- [PULL 02/34] target/arm: Drop access_el3_aa32ns_aa64any(), Peter Maydell, 2020/05/11
- [PULL 04/34] aspeed: sdmc: Implement AST2600 locking behaviour, Peter Maydell, 2020/05/11
- [PULL 03/34] aspeed: Support AST2600A1 silicon revision, Peter Maydell, 2020/05/11
- [PULL 05/34] hw/arm/nrf51: Add NRF51_PERIPHERAL_SIZE definition, Peter Maydell, 2020/05/11
- [PULL 06/34] hw/timer/nrf51_timer: Display timer ID in trace events, Peter Maydell, 2020/05/11
- [PULL 08/34] exec: Add block comments for watchpoint routines, Peter Maydell, 2020/05/11
- [PULL 09/34] exec: Fix cpu_watchpoint_address_matches address length, Peter Maydell, 2020/05/11
- [PULL 10/34] accel/tcg: Add block comment for probe_access, Peter Maydell, 2020/05/11
- [PULL 11/34] accel/tcg: Adjust probe_access call to page_check_range,
Peter Maydell <=
- [PULL 07/34] hw/timer/nrf51_timer: Add trace event of counter value update, Peter Maydell, 2020/05/11
- [PULL 13/34] accel/tcg: Add endian-specific cpu_{ld, st}* operations, Peter Maydell, 2020/05/11
- [PULL 15/34] target/arm: Drop manual handling of set/clear_helper_retaddr, Peter Maydell, 2020/05/11
- [PULL 14/34] target/arm: Use cpu_*_data_ra for sve_ldst_tlb_fn, Peter Maydell, 2020/05/11
- [PULL 16/34] target/arm: Add sve infrastructure for page lookup, Peter Maydell, 2020/05/11
- [PULL 18/34] target/arm: Use SVEContLdSt in sve_ld1_r, Peter Maydell, 2020/05/11
- [PULL 12/34] accel/tcg: Add probe_access_flags, Peter Maydell, 2020/05/11
- [PULL 17/34] target/arm: Adjust interface of sve_ld1_host_fn, Peter Maydell, 2020/05/11
- [PULL 19/34] target/arm: Handle watchpoints in sve_ld1_r, Peter Maydell, 2020/05/11
- [PULL 20/34] target/arm: Use SVEContLdSt for multi-register contiguous loads, Peter Maydell, 2020/05/11