[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 08/10] hw/core/resettable: add support for warm reset
From: |
Damien Hedde |
Subject: |
Re: [PATCH v4 08/10] hw/core/resettable: add support for warm reset |
Date: |
Mon, 11 May 2020 11:37:26 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
Hi Philippe,
On 5/10/20 10:17 PM, Philippe Mathieu-Daudé wrote:
> Hi Damien,
>
> On 8/21/19 6:33 PM, Damien Hedde wrote:
>> Add the RESET_TYPE_WARM reset type.
>> Expand the actual implementation to support several types.
>>
>> /**
>> * ResetType:
>> - * Types of reset.
>> + * Types of reset, values can be OR'ed together.
>> *
>> * + Cold: reset resulting from a power cycle of the object.
>> - *
>> - * TODO: Support has to be added to handle more types. In particular,
>> - * ResetState structure needs to be expanded.
>> + * + Warm: reset without power cycling.
>> */
>> typedef enum ResetType {
>> - RESET_TYPE_COLD,
>> + RESET_TYPE_COLD = 0x1,
>> + RESET_TYPE_WARM = 0x2,
>
> I'm a bit lost with the various iterations, what is the plan with warm
> reset, is this blocked due to discussion, API, something else?
>
I removed it in the last versions of the series because it was adding
complexity. There were unsolved issues and discussions, in particular
regarding the interactions and propagation along trees between the
different types.
Damien