Re: [PATCH 08/12] hw/pci-host/bonito: Map all the Bonito64 I/O range

[Aleksandar Markovic]

нед, 10. мај 2020. у 23:01 Philippe Mathieu-Daudé <address@hidden> је
написао/ла:
>
> To ease following guest accesses to the Bonito64 chipset,
> map its I/O range as UnimplementedDevice.
> We can now see the accesses to unimplemented peripheral
> using the '-d unimp' command line option.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  hw/pci-host/bonito.c | 3 +++
>  hw/pci-host/Kconfig  | 1 +
>  2 files changed, 4 insertions(+)
>

Reviewed-by: Aleksandar Markovic <address@hidden>

> diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c
> index 7ed462ffb5..9761780f44 100644
> --- a/hw/pci-host/bonito.c
> +++ b/hw/pci-host/bonito.c
> @@ -48,6 +48,7 @@
>  #include "sysemu/reset.h"
>  #include "sysemu/runstate.h"
>  #include "exec/address-spaces.h"
> +#include "hw/misc/unimp.h"
>
>  /* #define DEBUG_BONITO */
>
> @@ -644,6 +645,8 @@ static void bonito_realize(PCIDevice *dev, Error **errp)
>      sysbus_init_mmio(sysbus, &phb->data_mem);
>      sysbus_mmio_map(sysbus, 2, BONITO_SPCICONFIG_BASE);
>
> +    create_unimplemented_device("bonito", BONITO_REG_BASE, BONITO_REG_SIZE);
> +
>      memory_region_init_io(&s->iomem_ldma, OBJECT(s), &bonito_ldma_ops, s,
>                            "ldma", 0x100);
>      sysbus_init_mmio(sysbus, &s->iomem_ldma);
> diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig
> index 8db41edc7e..036a61877a 100644
> --- a/hw/pci-host/Kconfig
> +++ b/hw/pci-host/Kconfig
> @@ -58,4 +58,5 @@ config PCI_EXPRESS_DESIGNWARE
>
>  config PCI_BONITO
>      select PCI
> +    select UNIMP
>      bool
> --
> 2.21.3
>