[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/12] hw/mips/fuloong2e: Move code and update a comment
From: |
chen huacai |
Subject: |
Re: [PATCH 03/12] hw/mips/fuloong2e: Move code and update a comment |
Date: |
Mon, 11 May 2020 09:15:41 +0800 |
Reviewed-by: Huacai Chen <address@hidden>
On Mon, May 11, 2020 at 5:03 AM Philippe Mathieu-Daudé <address@hidden> wrote:
>
> Move the RAM-related call closer to the RAM creation block,
> rename the ROM comment.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/mips/mips_fulong2e.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
> index f067fa9720..4e1a3646af 100644
> --- a/hw/mips/mips_fulong2e.c
> +++ b/hw/mips/mips_fulong2e.c
> @@ -316,12 +316,11 @@ static void mips_fulong2e_init(MachineState *machine)
> error_report("Invalid RAM size, should be 256MB");
> exit(EXIT_FAILURE);
> }
> + memory_region_add_subregion(address_space_mem, 0, machine->ram);
>
> - /* allocate RAM */
> + /* Boot ROM */
> memory_region_init_rom(bios, NULL, "fulong2e.bios", BIOS_SIZE,
> &error_fatal);
> -
> - memory_region_add_subregion(address_space_mem, 0, machine->ram);
> memory_region_add_subregion(address_space_mem, 0x1fc00000LL, bios);
>
> /*
> --
> 2.21.3
>
>
--
Huacai Chen
- [PATCH 00/12] hw/mips/fuloong2e: PoC to fix hang after reboot, Philippe Mathieu-Daudé, 2020/05/10
- [PATCH 01/12] MAINTAINERS: Add Huacai Chen as fuloong2e co-maintainer, Philippe Mathieu-Daudé, 2020/05/10
- [PATCH 02/12] hw/mips/fuloong2e: Rename PMON BIOS name, Philippe Mathieu-Daudé, 2020/05/10
- [PATCH 05/12] hw/pci-host: Use CONFIG_PCI_BONITO to select the Bonito North Bridge, Philippe Mathieu-Daudé, 2020/05/10
- [PATCH 03/12] hw/mips/fuloong2e: Move code and update a comment, Philippe Mathieu-Daudé, 2020/05/10
- Re: [PATCH 03/12] hw/mips/fuloong2e: Move code and update a comment,
chen huacai <=
- [PATCH 04/12] hw/mips/fuloong2e: Fix typo in Fuloong machine name, Philippe Mathieu-Daudé, 2020/05/10
- Re: [PATCH 04/12] hw/mips/fuloong2e: Fix typo in Fuloong machine name, chen huacai, 2020/05/10
- Re: [PATCH 04/12] hw/mips/fuloong2e: Fix typo in Fuloong machine name, Aleksandar Markovic, 2020/05/11
- Re: [PATCH 04/12] hw/mips/fuloong2e: Fix typo in Fuloong machine name, Philippe Mathieu-Daudé, 2020/05/11
- Re: [PATCH 04/12] hw/mips/fuloong2e: Fix typo in Fuloong machine name, chen huacai, 2020/05/11
- Re: [PATCH 04/12] hw/mips/fuloong2e: Fix typo in Fuloong machine name, Aleksandar Markovic, 2020/05/11
- Re: [PATCH 04/12] hw/mips/fuloong2e: Fix typo in Fuloong machine name, Aleksandar Markovic, 2020/05/11
- Re: [PATCH 04/12] hw/mips/fuloong2e: Fix typo in Fuloong machine name, Philippe Mathieu-Daudé, 2020/05/12
[PATCH 06/12] hw/pci-host/bonito: Fix DPRINTF() format strings, Philippe Mathieu-Daudé, 2020/05/10