[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size
From: |
Christian Schoenebeck |
Subject: |
Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size |
Date: |
Sun, 10 May 2020 20:43:41 +0200 |
On Sonntag, 10. Mai 2020 19:18:21 CEST Christian Schoenebeck wrote:
> Commit SHA-1 16724a173049ac29c7b5ade741da93a0f46edff7 introduced
> truncating the response to the currently available transport buffer
> size, which was supposed to fix an 9pfs error on Xen boot where
> transport buffer might still be smaller than required for response.
>
> Unfortunately this change broke small reads (with less than 12
> bytes).
>
> To address both concerns, check the actual response type and only
> truncate reply for Rreaddir responses, and only if truncated reply
> would at least return one payload byte to client. Use Rreaddir's
> precise header size (11) for this instead of P9_IOHDRSZ.
Oops, that should have been "Rread's" of course, not "Rreaddir's". Apparently
I already spent too much time on readdir() code.
If there's not more to do, then maybe you could just amend this log message
typo Greg? I would appreciate it.
Best regards,
Christian Schoenebeck
- [PATCH 0/2] 9pfs: regression init_in_iov_from_pdu truncating size, Christian Schoenebeck, 2020/05/10
- [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Christian Schoenebeck, 2020/05/10
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size,
Christian Schoenebeck <=
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Stefano Stabellini, 2020/05/11
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Christian Schoenebeck, 2020/05/12
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Stefano Stabellini, 2020/05/12
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Christian Schoenebeck, 2020/05/13
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Stefano Stabellini, 2020/05/13
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Christian Schoenebeck, 2020/05/14
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Stefano Stabellini, 2020/05/14
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Christian Schoenebeck, 2020/05/14
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Stefano Stabellini, 2020/05/14
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Stefano Stabellini, 2020/05/14