[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 07/19] tcg: Use tcg_constant_{i32,i64,vec} with tcg gvec e
From: |
Richard Henderson |
Subject: |
Re: [PATCH v4 07/19] tcg: Use tcg_constant_{i32,i64,vec} with tcg gvec expanders |
Date: |
Fri, 8 May 2020 12:22:32 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/8/20 11:26 AM, Richard Henderson wrote:
> @@ -1647,16 +1632,14 @@ static void gen_addv_mask(TCGv_i64 d, TCGv_i64 a,
> TCGv_i64 b, TCGv_i64 m)
>
> void tcg_gen_vec_add8_i64(TCGv_i64 d, TCGv_i64 a, TCGv_i64 b)
> {
> - TCGv_i64 m = tcg_const_i64(dup_const(MO_8, 0x80));
> + TCGv_i64 m = tcg_constant_i64(dup_const(MO_8, 0x80));
> gen_addv_mask(d, a, b, m);
> - tcg_temp_free_i64(m);
> }
>
These unconditional uses of tcg_constant_i64 break 32-bit builds.
I'll have to find another way to handle these.
For now I am dropping this patch.
r~
- [PATCH v4 00/19] tcg: Better handling of constants, Richard Henderson, 2020/05/08
- [PATCH v4 02/19] tcg: Add temp_readonly, Richard Henderson, 2020/05/08
- [PATCH v4 01/19] tcg: Consolidate 3 bits into enum TCGTempKind, Richard Henderson, 2020/05/08
- [PATCH v4 03/19] tcg: Introduce TYPE_CONST temporaries, Richard Henderson, 2020/05/08
- [PATCH v4 04/19] tcg: Use tcg_constant_i32 with icount expander, Richard Henderson, 2020/05/08
- [PATCH v4 06/19] tcg: Use tcg_constant_{i32, vec} with tcg vec expanders, Richard Henderson, 2020/05/08
- [PATCH v4 05/19] tcg: Use tcg_constant_{i32, i64} with tcg int expanders, Richard Henderson, 2020/05/08
- [PATCH v4 07/19] tcg: Use tcg_constant_{i32, i64, vec} with tcg gvec expanders, Richard Henderson, 2020/05/08
- Re: [PATCH v4 07/19] tcg: Use tcg_constant_{i32,i64,vec} with tcg gvec expanders,
Richard Henderson <=
- [PATCH v4 08/19] tcg: Use tcg_constant_{i32,i64} with tcg plugins, Richard Henderson, 2020/05/08
- [PATCH v4 09/19] tcg: Rename struct tcg_temp_info to TempOptInfo, Richard Henderson, 2020/05/08
- [PATCH v4 10/19] tcg/optimize: Improve find_better_copy, Richard Henderson, 2020/05/08
- [PATCH v4 11/19] tcg/optimize: Adjust TempOptInfo allocation, Richard Henderson, 2020/05/08
- [PATCH v4 12/19] tcg/optimize: Use tcg_constant_internal with constant folding, Richard Henderson, 2020/05/08
- [PATCH v4 14/19] tcg: Remove movi and dupi opcodes, Richard Henderson, 2020/05/08
- [PATCH v4 13/19] tcg/tci: Add special tci_movi_{i32,i64} opcodes, Richard Henderson, 2020/05/08
- [PATCH v4 15/19] tcg: Use tcg_out_dupi_vec from temp_load, Richard Henderson, 2020/05/08
- [PATCH v4 16/19] tcg: Increase tcg_out_dupi_vec immediate to int64_t, Richard Henderson, 2020/05/08
- [PATCH v4 18/19] tcg/i386: Use tcg_constant_vec with tcg vec expanders, Richard Henderson, 2020/05/08