Re: [PATCH v2 2/6] blockdev: Split off basic bitmap operations for qemu-img

[Eric Blake]

On 5/8/20 6:37 AM, Kevin Wolf wrote:

> > > > ---
> > > >    Makefile.objs             |   2 +-
> > > >    include/sysemu/blockdev.h |  14 ++
> > > >    blockbitmaps.c            | 324 ++++++++++++++++++++++++++++++++++++++
> > >
> > > Hm.  Can we get a better name?  blockdev-bitmaps.c, for example?
> >
> > Sure, I'm open to bike-shed suggestions.  I'd also _really_ love to make the
> > new file NOT live in the top-level, but that's a harder task that I'm not
> > sure how to do (it's easy to tweak Makefile.objs for another file in the
> > same directory, but harder to see through the magic to figure out how to
> > relocate things).
>
> Yes, please move it somewhere else. I'd suggest something like
> block/monitor/bitmap-qmp-cmds.c for the QMP command handlers, and if
> there are functions that are more generally useful, block/bitmaps.c.
>
> Instead of modifying the top-level Makefile.objs, you would just edit
> block/monitor/Makefile.objs instead and add the filename there. I don't
> think you need to understand any magic apart from knowing that is exists
> and does what you would expect.

Well, you still have to modify the top-level Makefile.objs to tell it to 
look in the right subdirectories, but I got it figured out finally.  v3 
will use block/monitor/bitmap-qmp-cmds.c.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org