[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V3 02/14] KVM: MIPS: Fix VPN2_MASK definition for variable cp
From: |
Aleksandar Markovic |
Subject: |
Re: [PATCH V3 02/14] KVM: MIPS: Fix VPN2_MASK definition for variable cpu_vmbits |
Date: |
Fri, 8 May 2020 12:14:40 +0200 |
нед, 3. мај 2020. у 12:07 Huacai Chen <address@hidden> је написао/ла:
>
> From: Xing Li <address@hidden>
>
> If a CPU support more than 32bit vmbits (which is true for 64bit CPUs),
> VPN2_MASK set to fixed 0xffffe000 will lead to a wrong EntryHi in some
> functions such as _kvm_mips_host_tlb_inv().
>
> The cpu_vmbits definition of 32bit CPU in cpu-features.h is 31, so we
> still use the old definition.
>
> Cc: address@hidden
> Signed-off-by: Xing Li <address@hidden>
> [Huacai: Improve commit messages]
> Signed-off-by: Huacai Chen <address@hidden>
> ---
> arch/mips/include/asm/kvm_host.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/mips/include/asm/kvm_host.h
> b/arch/mips/include/asm/kvm_host.h
> index a01cee9..caa2b936 100644
> --- a/arch/mips/include/asm/kvm_host.h
> +++ b/arch/mips/include/asm/kvm_host.h
> @@ -274,7 +274,11 @@ enum emulation_result {
> #define MIPS3_PG_SHIFT 6
> #define MIPS3_PG_FRAME 0x3fffffc0
>
> +#if defined(CONFIG_64BIT)
> +#define VPN2_MASK GENMASK(cpu_vmbits - 1, 13)
> +#else
> #define VPN2_MASK 0xffffe000
> +#endif
> #define KVM_ENTRYHI_ASID cpu_asid_mask(&boot_cpu_data)
> #define TLB_IS_GLOBAL(x) ((x).tlb_lo[0] & (x).tlb_lo[1] & ENTRYLO_G)
> #define TLB_VPN2(x) ((x).tlb_hi & VPN2_MASK)
> --
> 2.7.0
>
Reviewed-by: Aleksandar Markovic <address@hidden>
- [PATCH V3 00/14] KVM: MIPS: Add Loongson-3 support (Host Side), Huacai Chen, 2020/05/03
- [PATCH V3 01/14] KVM: MIPS: Define KVM_ENTRYHI_ASID to cpu_asid_mask(&boot_cpu_data), Huacai Chen, 2020/05/03
- [PATCH V3 02/14] KVM: MIPS: Fix VPN2_MASK definition for variable cpu_vmbits, Huacai Chen, 2020/05/03
- Re: [PATCH V3 02/14] KVM: MIPS: Fix VPN2_MASK definition for variable cpu_vmbits,
Aleksandar Markovic <=
- [PATCH V3 03/14] KVM: MIPS: Increase KVM_MAX_VCPUS and KVM_USER_MEM_SLOTS to 16, Huacai Chen, 2020/05/03
- [PATCH V3 04/14] KVM: MIPS: Add EVENTFD support which is needed by VHOST, Huacai Chen, 2020/05/03
- [PATCH V3 05/14] KVM: MIPS: Use lddir/ldpte instructions to lookup gpa_mm.pgd, Huacai Chen, 2020/05/03
- [PATCH V3 06/14] KVM: MIPS: Introduce and use cpu_guest_has_ldpte, Huacai Chen, 2020/05/03
- [PATCH V3 07/14] KVM: MIPS: Use root tlb to control guest's CCA for Loongson-3, Huacai Chen, 2020/05/03