[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 06/12] migration/colo: Add missing error-propagation code
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[PULL 06/12] migration/colo: Add missing error-propagation code |
Date: |
Thu, 7 May 2020 18:02:05 +0100 |
From: Philippe Mathieu-Daudé <address@hidden>
Running the coccinelle script produced:
$ spatch \
--macro-file scripts/cocci-macro-file.h --include-headers \
--sp-file scripts/coccinelle/find-missing-error_propagate.cocci \
--keep-comments --smpl-spacing --dir .
HANDLING: ./migration/colo.c
[[manual check required: error_propagate() might be missing in
migrate_set_block_enabled() ./migration/colo.c:439:4]]
Add the missing error_propagate() after review.
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
migration/colo.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/migration/colo.c b/migration/colo.c
index 1b3493729b..d015d4f84e 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -443,6 +443,9 @@ static int colo_do_checkpoint_transaction(MigrationState *s,
/* Disable block migration */
migrate_set_block_enabled(false, &local_err);
+ if (local_err) {
+ goto out;
+ }
qemu_mutex_lock_iothread();
#ifdef CONFIG_REPLICATION
--
2.26.2
- [PULL 00/12] migration queue, Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 03/12] monitor/hmp-cmds: add hmp_handle_error() for hmp_migrate_set_speed(), Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 04/12] migration: move the units of migrate parameters from milliseconds to ms, Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 01/12] migration: fix bad indentation in error_report(), Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 02/12] migration/migration: improve error reporting for migrate parameters, Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 06/12] migration/colo: Add missing error-propagation code,
Dr. David Alan Gilbert (git) <=
- [PULL 05/12] docs/devel/migration: start a debugging section, Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 07/12] migration/throttle: Add cpu-throttle-tailslow migration parameter, Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 08/12] migration/ram: Consolidate variable reset after placement in ram_load_postcopy(), Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 09/12] migration/rdma: fix a memleak on error path in rdma_start_incoming_migration, Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 10/12] migration/xbzrle: add encoding rate, Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 11/12] migration/multifd: fix memleaks in multifd_new_send_channel_async, Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 12/12] migration/multifd: Do error_free after migrate_set_error to avoid memleaks, Dr. David Alan Gilbert (git), 2020/05/07
- Re: [PULL 00/12] migration queue, Peter Maydell, 2020/05/07