[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 19/31] qcow2: Add subcluster support to calculate_l2_meta(
From: |
Alberto Garcia |
Subject: |
Re: [PATCH v5 19/31] qcow2: Add subcluster support to calculate_l2_meta() |
Date: |
Thu, 07 May 2020 17:34:18 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Wed 06 May 2020 07:39:48 PM CEST, Eric Blake wrote:
> In fact, if we rely on 20/31 checking for invalid subclusters when
> computing nb_clusters, we could probably assert that the start and end
> cluster in this function are not invalid, instead of adding the fail:
> label.
I think you're right with that, good catch! There's no need to return an
error code in this function.
Berto
- Re: [PATCH v5 07/31] qcow2: Document the Extended L2 Entries feature, (continued)
[PATCH v5 04/31] qcow2: Split cluster_needs_cow() out of count_cow_clusters(), Alberto Garcia, 2020/05/05
[PATCH v5 23/31] qcow2: Add subcluster support to check_refcounts_l2(), Alberto Garcia, 2020/05/05
[PATCH v5 19/31] qcow2: Add subcluster support to calculate_l2_meta(), Alberto Garcia, 2020/05/05
[PATCH v5 16/31] qcow2: Add cluster type parameter to qcow2_get_host_offset(), Alberto Garcia, 2020/05/05
[PATCH v5 25/31] qcow2: Clear the L2 bitmap when allocating a compressed cluster, Alberto Garcia, 2020/05/05
[PATCH v5 26/31] qcow2: Add subcluster support to handle_alloc_space(), Alberto Garcia, 2020/05/05
Re: [PATCH v5 00/31] Add subcluster allocation to qcow2, Derek Su, 2020/05/20