[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 09/13] microvm: add minimal acpi support
|
From: |
Igor Mammedov |
|
Subject: |
Re: [PATCH v2 09/13] microvm: add minimal acpi support |
|
Date: |
Wed, 6 May 2020 16:14:19 +0200 |
On Wed, 6 May 2020 12:35:49 +0200
Gerd Hoffmann <address@hidden> wrote:
> > > +/* FIXME: copy & paste */
> > > +static void acpi_dsdt_add_power_button(Aml *scope)
> > > +{
> > > + Aml *dev = aml_device(ACPI_POWER_BUTTON_DEVICE);
> > > + aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C")));
> > > + aml_append(dev, aml_name_decl("_UID", aml_int(0)));
> > > + aml_append(scope, dev);
> > > +}
> >
> > could be unified with ARM's version
>
> Yep. Suggestions for a good place? hw/acpi/aml-build.c ?
sounds good to me
>
> > > + acpi_align_size(tables_blob, ACPI_BUILD_TABLE_SIZE);
> > > + acpi_align_size(tables->linker->cmd_blob, ACPI_BUILD_ALIGN_SIZE);
> > I'd drop these as that was mostly to counter various migration issues on
> > legacy
>
> Dropped.
>
> take care,
> Gerd
>
>
- [PATCH v2 06/13] acpi: move acpi_align_size to acpi-common.h, (continued)
[PATCH v2 03/13] acpi: madt: skip pci override on pci-less systems (microvm), Gerd Hoffmann, 2020/05/05
[PATCH v2 11/13] microvm: add acpi_dsdt_add_virtio() for x86, Gerd Hoffmann, 2020/05/05
[PATCH v2 13/13] microvm/acpi: use GSI 16-23 for virtio, Gerd Hoffmann, 2020/05/05
[PATCH v2 04/13] acpi: move acpi_build_facs to acpi-common.c, Gerd Hoffmann, 2020/05/05