[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] 9pfs: Fix potential deadlock of QEMU mainloop
|
From: |
Christian Schoenebeck |
|
Subject: |
Re: [PATCH] 9pfs: Fix potential deadlock of QEMU mainloop |
|
Date: |
Wed, 06 May 2020 15:36:16 +0200 |
On Mittwoch, 6. Mai 2020 15:05:23 CEST Christian Schoenebeck wrote:
> > diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> > index 9e046f7acb51..ac84ae804496 100644
> > --- a/hw/9pfs/9p.c
> > +++ b/hw/9pfs/9p.c
> > @@ -2170,7 +2170,7 @@ static int coroutine_fn
> > v9fs_do_readdir_with_stat(V9fsPDU *pdu, int32_t count = 0;
> >
> > struct stat stbuf;
> > off_t saved_dir_pos;
> >
> > - struct dirent *dent;
> > + struct dirent dent;
One more: since this dirent structure is now on the stack, it should better be
initialized for safety reasons.
Best regards,
Christian Schoenebeck