Re: [PATCH v2 08/13] acpi: generic event device for x86

[Igor Mammedov]

On Wed, 6 May 2020 12:31:06 +0200
Gerd Hoffmann <address@hidden> wrote:

> On Tue, May 05, 2020 at 05:03:16PM +0200, Igor Mammedov wrote:
> > On Tue,  5 May 2020 15:43:00 +0200
> > Gerd Hoffmann <address@hidden> wrote:
> >   
> > > Uses TYPE_ACPI_GED as QOM parent for code reuse.
> > > Add registers for sleep states and reset.
> > > Add powerdown notifier for power button events.  
> > registers aren't x86 specific per spec,
> > can we put these registers into TYPE_ACPI_GED
> > and enable the optionally like is done with memory hotplug registers
> > in acpi_ged_initfn()  
> 
> Sure, will do.
> 
> > > Set AcpiDeviceIfClass->madt_cpu.  
> > that's the only reason I could justify adding x86 specific flavour.  
> 
> Also the powerdown notifier.  Seems the workflow is slightly different
> on x86 (acpi device registers notifier) and arm (machine registers
> notifier and calls acpidev->send_event).

Is it possible to use ARM's approach, without notifier?

> 
> take care,
>   Gerd
>