Re: [PATCH v2 05/18] qom: Drop convenience method object_property_get_uint16List()

[Paolo Bonzini]

On 05/05/20 17:29, Markus Armbruster wrote:
> qom/object.c provides object_property_get_TYPE() and
> object_property_set_TYPE() for a number of common types.  These are
> all convenience wrappers around object_property_get_qobject() and
> object_property_set_qobject().
> 
> Except for object_property_get_uint16List(), which is unusual in two ways:
> 
> * It bypasses object_property_get_qobject().  Fixable; the previous
>   commit did it for object_property_get_enum())
> 
> * It stores the value through a parameter.  Its contract claims it
>   returns the value, like the other functions do.  Also fixable.
> 
> Fixing is not worthwhile, though: object_property_get_uint16List() has
> seen exactly one user in six years.
> 
> Convert the lone user to do its job with the generic
> object_property_get_qobject(), and drop object_property_get_qobject().

Typo, otherwise

Reviewed-by: Paolo Bonzini <address@hidden>

Paolo

> Signed-off-by: Markus Armbruster <address@hidden>