Re: [PATCH v18 QEMU 18/18] qapi: Add VFIO devices migration stats in Migration stats

[Eric Blake]

On 5/4/20 5:44 PM, Kirti Wankhede wrote:
> Added amount of bytes transferred to the target VM by all VFIO devices
>
> Signed-off-by: Kirti Wankhede <address@hidden>
> ---

Reviewing just the UI:

> +++ b/qapi/migration.json
> @@ -144,6 +144,18 @@
>               'active', 'postcopy-active', 'postcopy-paused',
>               'postcopy-recover', 'completed', 'failed', 'colo',
>               'pre-switchover', 'device', 'wait-unplug' ] }
> +##
> +# @VfioStats:
> +#
> +# Detailed VFIO devices migration statistics
> +#
> +# @bytes: amount of bytes transferred to the target VM by VFIO devices
> +#
> +# Since: 5.0

s/5.0/5.1/

> +#
> +##
> +{ 'struct': 'VfioStats',
> +  'data': {'bytes': 'int' } }
>   
>   ##
>   # @MigrationInfo:
> @@ -205,6 +217,10 @@
>   #
>   # @socket-address: Only used for tcp, to know what the real port is (Since 
> 4.0)
>   #
> +# @vfio: @VfioStats containing detailed VFIO devices migration statistics,
> +#        only returned if VFIO device is present, migration is supported by all
> +#         VFIO devices and status is 'active' or 'completed' (since 5.0)

here too

> +#
>   # Since: 0.14.0
>   ##
>   { 'struct': 'MigrationInfo',
> @@ -220,7 +236,8 @@
>              '*postcopy-blocktime' : 'uint32',
>              '*postcopy-vcpu-blocktime': ['uint32'],
>              '*compression': 'CompressionStats',
> -           '*socket-address': ['SocketAddress'] } }
> +           '*socket-address': ['SocketAddress'],
> +           '*vfio': 'VfioStats' } }
>   
>   ##
>   # @query-migrate:

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org