RE: [PATCH v2 02/10] xen: Fix and improve handling of device_add usb-host errors

[Paul Durrant]

> -----Original Message-----
> From: Markus Armbruster <address@hidden>
> Sent: 05 May 2020 11:19
> To: address@hidden
> Cc: Stefano Stabellini <address@hidden>; Anthony Perard <address@hidden>; Paul
> Durrant <address@hidden>; Gerd Hoffmann <address@hidden>; address@hidden
> Subject: [PATCH v2 02/10] xen: Fix and improve handling of device_add 
> usb-host errors
> 
> usbback_portid_add() leaks the error when qdev_device_add() fails.
> Fix that.  While there, use the error to improve the error message.
> 
> The qemu_opts_from_qdict() similarly leaks on failure.  But any
> failure there is a programming error.  Pass &error_abort.
> 
> Fixes: 816ac92ef769f9ffc534e49a1bb6177bddce7aa2
> Cc: Stefano Stabellini <address@hidden>
> Cc: Anthony Perard <address@hidden>
> Cc: Paul Durrant <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Cc: address@hidden
> Signed-off-by: Markus Armbruster <address@hidden>

Acked-by: Paul Durrant <address@hidden>