[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 08/10] mips/boston: Plug memory leak in boston_mach_init()
From: |
Markus Armbruster |
Subject: |
[PATCH v2 08/10] mips/boston: Plug memory leak in boston_mach_init() |
Date: |
Tue, 5 May 2020 12:19:06 +0200 |
Fixes: df1d8a1f29f567567b9d20be685a4241282e7005
Cc: Paul Burton <address@hidden>
Cc: Aleksandar Rikalo <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/mips/boston.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/mips/boston.c b/hw/mips/boston.c
index 2832dfa6ae..a896056be1 100644
--- a/hw/mips/boston.c
+++ b/hw/mips/boston.c
@@ -426,7 +426,6 @@ static void boston_mach_init(MachineState *machine)
{
DeviceState *dev;
BostonState *s;
- Error *err = NULL;
MemoryRegion *flash, *ddr_low_alias, *lcd, *platreg;
MemoryRegion *sys_mem = get_system_memory();
XilinxPCIEHost *pcie2;
@@ -467,7 +466,8 @@ static void boston_mach_init(MachineState *machine)
sysbus_mmio_map_overlap(SYS_BUS_DEVICE(&s->cps), 0, 0, 1);
flash = g_new(MemoryRegion, 1);
- memory_region_init_rom(flash, NULL, "boston.flash", 128 * MiB, &err);
+ memory_region_init_rom(flash, NULL, "boston.flash", 128 * MiB,
+ &error_fatal);
memory_region_add_subregion_overlap(sys_mem, 0x18000000, flash, 0);
memory_region_add_subregion_overlap(sys_mem, 0x80000000, machine->ram, 0);
--
2.21.1
- [PATCH v2 00/10] More miscellaneous error handling fixes, Markus Armbruster, 2020/05/05
- [PATCH v2 01/10] nvdimm: Plug memory leak in uuid property setter, Markus Armbruster, 2020/05/05
- [PATCH v2 08/10] mips/boston: Plug memory leak in boston_mach_init(),
Markus Armbruster <=
- [PATCH v2 04/10] tests/migration: Tighten error checking, Markus Armbruster, 2020/05/05
- [PATCH v2 09/10] arm/sabrelite: Consistently use &error_fatal in sabrelite_init(), Markus Armbruster, 2020/05/05
- [PATCH v2 07/10] mips/boston: Fix boston_mach_init() error handling, Markus Armbruster, 2020/05/05
- [PATCH v2 05/10] error: Use error_reportf_err() where appropriate, Markus Armbruster, 2020/05/05
- [PATCH v2 03/10] s390x/cpumodel: Fix harmless misuse of visit_check_struct(), Markus Armbruster, 2020/05/05
- [PATCH v2 06/10] mips/malta: Fix create_cps() error handling, Markus Armbruster, 2020/05/05