[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] hw/i386: Add 'vmport.h' local header
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 3/4] hw/i386: Add 'vmport.h' local header |
|
Date: |
Mon, 4 May 2020 10:25:29 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/4/20 1:33 AM, Philippe Mathieu-Daudé wrote:
> Move 'vmport' related declarations in a target-specific header.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/i386/vmport.h | 34 ++++++++++++++++++++++++++++++++++
> include/hw/i386/pc.h | 3 ---
> hw/i386/pc.c | 1 +
> hw/i386/vmmouse.c | 1 +
> hw/i386/vmport.c | 1 +
> 5 files changed, 37 insertions(+), 3 deletions(-)
> create mode 100644 hw/i386/vmport.h
> +typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address);
Maybe get rid of the useless parenthesis here.
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~