qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PULL 13/29] checkpatch: ignore allowed diff list


From: Michael S. Tsirkin
Subject: [PULL 13/29] checkpatch: ignore allowed diff list
Date: Mon, 4 May 2020 10:29:44 -0400

Allow changing allowed diff list at any point:
- when changing code under test
- when adding expected files

It's just a list of files so easy to review and merge anyway.

Signed-off-by: Michael S. Tsirkin <address@hidden>
---
 scripts/checkpatch.pl | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index c3d08aa99f..0ba213e9f2 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1261,12 +1261,13 @@ sub WARN {
 sub checkfilename {
        my ($name, $acpi_testexpected, $acpi_nontestexpected) = @_;
 
-       if ($name =~ m#^tests/data/acpi/# and
-               # make exception for a shell script that rebuilds the files
-               not $name =~ m#^\.sh$# or
-               $name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
+        # Note: shell script that rebuilds the expected files is in the same
+        # directory as files themselves.
+        # Note: allowed diff list can be changed both when changing expected
+        # files and when changing tests.
+       if ($name =~ m#^tests/data/acpi/# and not $name =~ m#^\.sh$#) {
                $$acpi_testexpected = $name;
-       } else {
+       } elsif ($name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
                $$acpi_nontestexpected = $name;
        }
        if (defined $$acpi_testexpected and defined $$acpi_nontestexpected) {
-- 
MST




reply via email to

[Prev in Thread] Current Thread [Next in Thread]