Re: [PATCH] chardev: enable distinct input for -chardev file

[Stefan Hajnoczi]

On Fri, May 01, 2020 at 01:25:59PM -0400, Alexander Bulekov wrote:
> char-file already supports distinct paths for input/output but it was
> only possible to specify a distinct input through QMP. With this change,
> we can also specify a distinct input with the -chardev file argument:
>     qemu -chardev file,id=char1,path=/out/file,in=/in/file
> 
> Signed-off-by: Alexander Bulekov <address@hidden>
> ---
>  chardev/char-file.c | 5 +++++
>  chardev/char.c      | 3 +++
>  qemu-options.hx     | 7 +++++--
>  3 files changed, 13 insertions(+), 2 deletions(-)
> 
> The naming here is awkward, with path= really turning into "out" when
> in= is specified, though i'm not sure about what is a good solution.

Reviewed-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature