Re: [PATCH v1 4/4] .travis.yml: reduce the load on [ppc64] GCC check-tcg

[David Gibson]

On Fri, May 01, 2020 at 01:58:47PM +0100, Alex Bennée wrote:
> 
> Philippe Mathieu-Daudé <address@hidden> writes:
> 
> > On 5/1/20 1:15 PM, Alex Bennée wrote:
> >> This seems to be timing out quite often and occasionally running out
> >> of disk space. Relegate it to light duties.
> >> Signed-off-by: Alex Bennée <address@hidden>
> >> ---
> >>   .travis.yml | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >> diff --git a/.travis.yml b/.travis.yml
> >> index 49267b73b3..fe708792ca 100644
> >> --- a/.travis.yml
> >> +++ b/.travis.yml
> >> @@ -458,7 +458,7 @@ jobs:
> >>             - genisoimage
> >>         env:
> >>           - TEST_CMD="make check check-tcg V=1"
> >> -        - CONFIG="--disable-containers 
> >> --target-list=${MAIN_SOFTMMU_TARGETS},ppc64le-linux-user"
> >> +        - CONFIG="--disable-containers 
> >> --target-list=ppc64-softmmu,ppc64le-linux-user"
> >
> > Cc'ing David, since I'm not sure about this one... Maybe split as we
> > did with other jobs?
> 
> We could do but it lengthens the run even more. Having
> ppc64le-linux-user ensures we exercise the majority of the TCG code
> generator so I think the only area we aren't covering is the PPC TCG
> softmmu backend. We could add another softmmu target but I didn't want
> to play favourites.

Hrm.  I'd prefer not to drop this coverage if we can avoid it.  What
we're not testing with the proposed patch is TCG generation for a ppc
host but a non-ppc target.  e.g. if the x86 or ARM target side generates
some pattern of TCG ops that's very rare for the ppc target, and is
buggy in the ppc host side.

I'll grant you, bugs that specific aren't particularly likely.  But,
such a regression would also be very unlikely to be caught by ad-hoc
testing, so it would be good to have at least some coverage in Travis.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature