[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] softfloat: fix floatx80 pseudo-denormal comparisons
From: |
Joseph Myers |
Subject: |
Re: [PATCH 3/4] softfloat: fix floatx80 pseudo-denormal comparisons |
Date: |
Fri, 1 May 2020 19:12:54 +0000 |
User-agent: |
Alpine 2.21 (DEB 202 2017-01-01) |
On Fri, 1 May 2020, Alex Bennée wrote:
>
> Joseph Myers <address@hidden> writes:
>
> > The softfloat floatx80 comparisons fail to allow for pseudo-denormals,
> > which should compare equal to corresponding values with biased
> > exponent 1 rather than 0. Add an adjustment for that case when
> > comparing numbers with the same sign.
> >
> > Note that this fix only changes floatx80_compare_internal, not the
> > other more specific comparison operations. That is the only
> > comparison function for floatx80 used in the i386 port, which is the
> > only supported port with these pseudo-denormal semantics.
>
> Again I can't see anything that triggers this although I noticed
> le_quiet has been fixed in the meantime. lt_quiet still fails with:
It looks like this test is only testing the separate comparison functions,
which aren't used in the i386 port and which I didn't change, not anything
that uses floatx80_compare_internal. (That's apart from probably not
covering pseudo-denormals either.)
--
Joseph S. Myers
address@hidden