[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 1/9] configure: favour gdb-multiarch if we have it
From: |
Alex Bennée |
Subject: |
Re: [PATCH v1 1/9] configure: favour gdb-multiarch if we have it |
Date: |
Fri, 01 May 2020 14:22:48 +0100 |
User-agent: |
mu4e 1.4.1; emacs 28.0.50 |
Philippe Mathieu-Daudé <address@hidden> writes:
> On 4/30/20 9:01 PM, Alex Bennée wrote:
>> As gdb will generally be talking to "foreign" guests lets use that if
>> we can. Otherwise the chances of gdb barfing are considerably higher.
>> Signed-off-by: Alex Bennée <address@hidden>
>> ---
>> configure | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/configure b/configure
>> index 23b5e93752..c58787100f 100755
>> --- a/configure
>> +++ b/configure
>> @@ -303,7 +303,7 @@ libs_qga=""
>> debug_info="yes"
>> stack_protector=""
>> use_containers="yes"
>> -gdb_bin=$(command -v "gdb")
>> +gdb_bin=$(command -v "gdb-multiarch" || command -v "gdb")
>> if test -e "$source_path/.git"
>> then
>>
>
> This was also already reviewed:
> https://www.mail-archive.com/address@hidden/msg697748.html
>
> There seem to be a problem in your workflow.
Ahh I was only calling:
#+CALL: check-and-fix-missing-signoffs()
in my PR workflow... fixed now thanks
--
Alex Bennée