Re: [PATCH v1 0/9] gdbstub/next

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [PATCH  v1 0/9] gdbstub/next
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
cbeaa01 target/m68k: fix gdb for m68xxx
0ef9fc4 tests/tcg: add a multiarch linux-user gdb test
2eaef59 tests/guest-debug: use the unix socket for linux-user tests
c0635bc gdbstub/linux-user: support debugging over a unix socket
bc7fbda gdbstub: eliminate gdbserver_fd global
9fc5b1f tests/tcg: drop inferior.was_attached() test
d5abc1a tests/tcg: better trap gdb failures
43ab101 gdbstub: Introduce gdb_get_float64() to get 64-bit float registers
b2085b3 configure: favour gdb-multiarch if we have it

=== OUTPUT BEGIN ===
1/9 Checking commit b2085b336372 (configure: favour gdb-multiarch if we have it)
2/9 Checking commit 43ab101ae057 (gdbstub: Introduce gdb_get_float64() to get 
64-bit float registers)
3/9 Checking commit d5abc1a10211 (tests/tcg: better trap gdb failures)
4/9 Checking commit 9fc5b1f56fbd (tests/tcg: drop inferior.was_attached() test)
5/9 Checking commit bc7fbda9f7e4 (gdbstub: eliminate gdbserver_fd global)
ERROR: suspect code indent for conditional statements (2, 6)
#34: FILE: gdbstub.c:2965:
+  if (gdbserver_state.fd < 0) {
       return;

total: 1 errors, 0 warnings, 74 lines checked

Patch 5/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/9 Checking commit c0635bc3b0e0 (gdbstub/linux-user: support debugging over a 
unix socket)
ERROR: suspect code indent for conditional statements (2, 6)
#67: FILE: gdbstub.c:2966:
+  if (gdbserver_state.socket_path) {
+      unlink(gdbserver_state.socket_path);

ERROR: space required before the open parenthesis '('
#93: FILE: gdbstub.c:3088:
+    for(;;) {

total: 2 errors, 0 warnings, 220 lines checked

Patch 6/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/9 Checking commit 2eaef5943ca6 (tests/guest-debug: use the unix socket for 
linux-user tests)
8/9 Checking commit 0ef9fc4e47a9 (tests/tcg: add a multiarch linux-user gdb 
test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#75: 
new file mode 100644

total: 0 errors, 1 warnings, 124 lines checked

Patch 8/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/9 Checking commit cbeaa014520b (target/m68k: fix gdb for m68xxx)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

total: 0 errors, 1 warnings, 105 lines checked

Patch 9/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden