[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/4] block: Use bdrv_make_empty() where possible
From: |
Max Reitz |
Subject: |
[PATCH v2 2/4] block: Use bdrv_make_empty() where possible |
Date: |
Wed, 29 Apr 2020 16:11:24 +0200 |
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
---
block/replication.c | 6 ++----
block/vvfat.c | 4 +---
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/block/replication.c b/block/replication.c
index da013c2041..cc6a40d577 100644
--- a/block/replication.c
+++ b/block/replication.c
@@ -331,9 +331,8 @@ static void secondary_do_checkpoint(BDRVReplicationState
*s, Error **errp)
return;
}
- ret = s->active_disk->bs->drv->bdrv_make_empty(s->active_disk->bs);
+ ret = bdrv_make_empty(s->active_disk, errp);
if (ret < 0) {
- error_setg(errp, "Cannot make active disk empty");
return;
}
@@ -343,9 +342,8 @@ static void secondary_do_checkpoint(BDRVReplicationState
*s, Error **errp)
return;
}
- ret = s->hidden_disk->bs->drv->bdrv_make_empty(s->hidden_disk->bs);
+ ret = bdrv_make_empty(s->hidden_disk, errp);
if (ret < 0) {
- error_setg(errp, "Cannot make hidden disk empty");
return;
}
}
diff --git a/block/vvfat.c b/block/vvfat.c
index 6d5c090dec..34c121c07a 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -2960,9 +2960,7 @@ static int do_commit(BDRVVVFATState* s)
return ret;
}
- if (s->qcow->bs->drv && s->qcow->bs->drv->bdrv_make_empty) {
- s->qcow->bs->drv->bdrv_make_empty(s->qcow->bs);
- }
+ bdrv_make_empty(s->qcow, NULL);
memset(s->used_clusters, 0, sector2cluster(s, s->sector_count));
--
2.25.4
- [PATCH v2 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly, Max Reitz, 2020/04/29
- [PATCH v2 2/4] block: Use bdrv_make_empty() where possible,
Max Reitz <=
- [PATCH v2 1/4] block: Add bdrv_make_empty(), Max Reitz, 2020/04/29
- [PATCH v2 4/4] block: Use blk_make_empty() after commits, Max Reitz, 2020/04/29
- [PATCH v2 3/4] block: Add blk_make_empty(), Max Reitz, 2020/04/29
- Re: [PATCH v2 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly, no-reply, 2020/04/29
- Re: [PATCH v2 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly, no-reply, 2020/04/29
- Re: [PATCH v2 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly, no-reply, 2020/04/29