[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 04/13] numa: Make all callbacks of ram block notifiers optiona
From: |
David Hildenbrand |
Subject: |
[PATCH v4 04/13] numa: Make all callbacks of ram block notifiers optional |
Date: |
Tue, 21 Apr 2020 10:52:51 +0200 |
Let's make add/remove optional. We want to introduce a RAM block
notifier for RAM migration, that's only interested in resizes.
Reviewed-by: Peter Xu <address@hidden>
Cc: Richard Henderson <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Cc: Eduardo Habkost <address@hidden>
Cc: Marcel Apfelbaum <address@hidden>
Cc: Peter Xu <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
hw/core/numa.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/hw/core/numa.c b/hw/core/numa.c
index fe6ca5c50d..37ce175e13 100644
--- a/hw/core/numa.c
+++ b/hw/core/numa.c
@@ -870,8 +870,11 @@ static int ram_block_notify_add_single(RAMBlock *rb, void
*opaque)
void ram_block_notifier_add(RAMBlockNotifier *n)
{
QLIST_INSERT_HEAD(&ram_list.ramblock_notifiers, n, next);
+
/* Notify about all existing ram blocks. */
- qemu_ram_foreach_block(ram_block_notify_add_single, n);
+ if (n->ram_block_added) {
+ qemu_ram_foreach_block(ram_block_notify_add_single, n);
+ }
}
void ram_block_notifier_remove(RAMBlockNotifier *n)
@@ -884,7 +887,9 @@ void ram_block_notify_add(void *host, size_t size, size_t
max_size)
RAMBlockNotifier *notifier;
QLIST_FOREACH(notifier, &ram_list.ramblock_notifiers, next) {
- notifier->ram_block_added(notifier, host, size, max_size);
+ if (notifier->ram_block_added) {
+ notifier->ram_block_added(notifier, host, size, max_size);
+ }
}
}
@@ -893,7 +898,9 @@ void ram_block_notify_remove(void *host, size_t size,
size_t max_size)
RAMBlockNotifier *notifier;
QLIST_FOREACH(notifier, &ram_list.ramblock_notifiers, next) {
- notifier->ram_block_removed(notifier, host, size, max_size);
+ if (notifier->ram_block_removed) {
+ notifier->ram_block_removed(notifier, host, size, max_size);
+ }
}
}
--
2.25.1
- [PATCH v4 00/13] migrate/ram: Fix resizing RAM blocks while migrating, David Hildenbrand, 2020/04/21
- [PATCH v4 01/13] util: vfio-helpers: Factor out and fix processing of existing ram blocks, David Hildenbrand, 2020/04/21
- [PATCH v4 03/13] numa: Teach ram block notifiers about resizeable ram blocks, David Hildenbrand, 2020/04/21
- [PATCH v4 04/13] numa: Make all callbacks of ram block notifiers optional,
David Hildenbrand <=
- [PATCH v4 05/13] migration/ram: Handle RAM block resizes during precopy, David Hildenbrand, 2020/04/21
- [PATCH v4 02/13] stubs/ram-block: Remove stubs that are no longer needed, David Hildenbrand, 2020/04/21
- [PATCH v4 06/13] exec: Relax range check in ram_block_discard_range(), David Hildenbrand, 2020/04/21
- [PATCH v4 07/13] migration/ram: Discard RAM when growing RAM blocks after ram_postcopy_incoming_init(), David Hildenbrand, 2020/04/21
- [PATCH v4 08/13] migration/ram: Simplify host page handling in ram_load_postcopy(), David Hildenbrand, 2020/04/21
- [PATCH v4 09/13] migration/ram: Consolidate variable reset after placement in ram_load_postcopy(), David Hildenbrand, 2020/04/21
- [PATCH v4 10/13] migration/ram: Handle RAM block resizes during postcopy, David Hildenbrand, 2020/04/21
- [PATCH v4 11/13] migration/multifd: Print used_length of memory block, David Hildenbrand, 2020/04/21
- [PATCH v4 12/13] migration/ram: Use offset_in_ramblock() in range checks, David Hildenbrand, 2020/04/21