Re: [PATCH v3] configure: warn if not using a separate build directory

[Eric Blake]

On 3/31/20 12:16 PM, Daniel P. Berrangé wrote:
> Running configure directly from the source directory is a build
> configuration that will go away in future. It is also not currently
> covered by any automated testing. Display a deprecation warning if
> the user attempts to use an in-srcdir build setup, so that they are
> aware that they're building QEMU in an undesirable manner.
>
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> ---
> +if test "$in_srcdir" = "yes"; then
> +    echo
> +    echo "WARNING: SUPPORT FOR IN SOURCE DIR BUILDS IS DEPRECATED"
> +    echo
> +    echo "Support for running the 'configure' script directly from the"
> +    echo "source directory is deprecated. In source dir builds are not"
> +    echo "covered by automated testing and thus may not correctly build"
> +    echo "QEMU. Users are recommended to use a separate build directory:"
Our mails crossed. I still think this reads a bit awkwardly; maybe:

s/IN SOURCE DIR BUILDS/BUILDING IN THE SOURCE DIR/
s/In source dir builds/In-tree builds/

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org