Re: [PATCH v3 30/34] qapi: Implement deprecated-output=hide for QMP event data

[Markus Armbruster]

Markus Armbruster <address@hidden> writes:

> This policy suppresses deprecated bits in output, and thus permits
> "testing the future".  Implement it for QMP event data: suppress
> deprecated members.
>
> No QMP event data is deprecated right now.
>
> Signed-off-by: Markus Armbruster <address@hidden>

Needs a fixup:

diff --git a/tests/test-qmp-event.c b/tests/test-qmp-event.c
index be5a2433d0..8f77485454 100644
--- a/tests/test-qmp-event.c
+++ b/tests/test-qmp-event.c
@@ -167,6 +167,8 @@ static void test_event_deprecated_data(TestEventData *data, 
const void *unused)
     qapi_event_send_test_event_features0(42);
     g_assert(data->emitted);
 
+    qobject_unref(data->expect);
+
     compat_policy.deprecated_output = COMPAT_POLICY_OUTPUT_HIDE;
     data->expect = qdict_from_jsonf_nofail("{ 'event': 'TEST-EVENT-FEATURES0' 
}");
     qapi_event_send_test_event_features0(42);
diff --git a/scripts/qapi/events.py b/scripts/qapi/events.py
index 78fa60aa8e..f03c825cc1 100644
--- a/scripts/qapi/events.py
+++ b/scripts/qapi/events.py
@@ -125,6 +125,8 @@ def gen_event_send(name, arg_type, features, boxed,
     visit_complete(v, &obj);
     if (qdict_size(qobject_to(QDict, obj))) {
         qdict_put_obj(qmp, "data", obj);
+    } else {
+        qobject_unref(obj);
     }
 ''')