Re: [PATCH v2 08/12] .travis.yml: Add description to each job

[Thomas Huth]

On 31/01/2020 16.24, Philippe Mathieu-Daudé wrote:
> On 1/30/20 8:06 PM, Thomas Huth wrote:
>> On 30/01/2020 12.32, Alex Bennée wrote:
>>> From: Philippe Mathieu-Daudé <address@hidden>
>>>
>>> The NAME variable can be used to describe nicely a job (see [*]).
>>> As we currently have 32 jobs, use it. This helps for quickly
>>> finding a particular job.
>>>
>>>    before: https://travis-ci.org/qemu/qemu/builds/639887646
>>>    after: https://travis-ci.org/philmd/qemu/builds/641795043
>>>
>>> [*]
>>> https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices
>>>
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>>> Message-Id: <address@hidden>
>>>
>>> ---
>>> [ajb]
>>>    - drop [x86]
>>> ---
>>>   .travis.yml | 101 ++++++++++++++++++++++++++++++++++------------------
>>>   1 file changed, 67 insertions(+), 34 deletions(-)
>>>
>>> diff --git a/.travis.yml b/.travis.yml
>>> index 7526967847..056db1adac 100644
>>> --- a/.travis.yml
>>> +++ b/.travis.yml
>>> @@ -96,24 +96,28 @@ after_script:
>>>     matrix:
>>>     include:
>>> -    - env:
>>> +    - name: "GCC static (user)"
>>> +      env:
>>>           - CONFIG="--disable-system --static"
>>>           - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>>           # we split the system builds as it takes a while to build
>>> them all
>>> -    - env:
>>> +    - name: "GCC (main-softmmu)"
>>> +      env:
>>>           - CONFIG="--disable-user
>>> --target-list=${MAIN_SOFTMMU_TARGETS}"
>>>           - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>>     -    - env:
>>> -        - CONFIG="--disable-user
>>> --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
>>> +    - name: "GCC (other-softmmu)"
>>> +      env:
>>> +       - CONFIG="--disable-user
>>> --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
>>>           - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>>           # Just build tools and run minimal unit and softfloat checks
>>> -    - env:
>>> +    - name: "GCC check-softfloat (user)"
>>> +      env:
>>>           - BASE_CONFIG="--enable-tools"
>>>           - CONFIG="--disable-user --disable-system"
>>>           - TEST_CMD="make check-unit check-softfloat -j3"
>>> @@ -121,41 +125,48 @@ matrix:
>>>           # --enable-debug implies --enable-debug-tcg, also runs
>>> quite a bit slower
>>> -    - env:
>>> +    - name: "GCC debug (main-softmmu)"
>>> +      env:
>>>           - CONFIG="--enable-debug
>>> --target-list=${MAIN_SOFTMMU_TARGETS}"
>>>           - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug"
>>>           # TCG debug can be run just on its own and is mostly
>>> agnostic to user/softmmu distinctions
>>> -    - env:
>>> +    - name: "GCC debug (user)"
>>> +      env:
>>>           - CONFIG="--enable-debug-tcg --disable-system"
>>>           - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg"
>>>     -    - env:
>>> +    - name: "GCC some libs disabled (main-softmmu)"
>>> +      env:
>>>           - CONFIG="--disable-linux-aio --disable-cap-ng
>>> --disable-attr --disable-brlapi --disable-libusb
>>> --disable-replication --target-list=${MAIN_SOFTMMU_TARGETS}"
>>>           # Module builds are mostly of interest to major distros
>>> -    - env:
>>> +    - name: "GCC modules (main-softmmu)"
>>> +      env:
>>>           - CONFIG="--enable-modules
>>> --target-list=${MAIN_SOFTMMU_TARGETS}"
>>>           - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>>           # Alternate coroutines implementations are only really of
>>> interest to KVM users
>>>       # However we can't test against KVM on Travis so we can only
>>> run unit tests
>>> -    - env:
>>> +    - name: "check-unit coroutine=ucontext"
>>> +      env:
>>>           - CONFIG="--with-coroutine=ucontext --disable-tcg"
>>>           - TEST_CMD="make check-unit -j3 V=1"
>>>     -    - env:
>>> +    - name: "check-unit coroutine=sigaltstack"
>>> +      env:
>>>           - CONFIG="--with-coroutine=sigaltstack --disable-tcg"
>>>           - TEST_CMD="make check-unit -j3 V=1"
>>>           # Check we can build docs and tools (out of tree)
>>> -    - env:
>>> +    - name: "[x86] tools and docs"
>>
>> Could you please also drop this "[x86]" here?
> 
> The hunk got applied into the next patch:
> 
>      # Check we can build docs and tools (out of tree)
> -    - name: "[x86] tools and docs"
> +    - name: "tools and docs (bionic)"
> +      dist: bionic

Ok, fine for me, too.

 Thomas