[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] git: Make submodule check only needed modules
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v2] git: Make submodule check only needed modules |
|
Date: |
Thu, 30 Jan 2020 16:46:18 +0000 |
|
User-agent: |
Mutt/1.13.3 (2020-01-12) |
On Thu, Jan 30, 2020 at 05:44:59PM +0100, Juan Quintela wrote:
> Daniel P. Berrangé <address@hidden> wrote:
> > On Thu, Jan 30, 2020 at 05:28:10PM +0100, Juan Quintela wrote:
> >> If one is compiling more than one tree from the same source, it is
> >> possible that they need different submodules. Change the check to see
> >> that all modules that we are interested in are updated, discarding the
> >> ones that we don't care about.
> >>
> >> Signed-off-by: Juan Quintela <address@hidden>
> >>
> >
> > Reviewed-by: Daniel P. Berrangé <address@hidden>
>
> Should I send the pull request?
Sure, I'm was leaving this for the "Misc queue" maintainer but if yuou
want it sooner....
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|