[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 01/21] softmmu: split off vl.c:main() into main.c
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH v8 01/21] softmmu: split off vl.c:main() into main.c |
|
Date: |
Thu, 30 Jan 2020 14:39:00 +0000 |
On Wed, Jan 29, 2020 at 05:34:11AM +0000, Bulekov, Alexander wrote:
> A program might rely on functions implemented in vl.c, but implement its
> own main(). By placing main into a separate source file, there are no
> complaints about duplicate main()s when linking against vl.o. For
> example, the virtual-device fuzzer uses a main() provided by libfuzzer,
> and needs to perform some initialization before running the softmmu
> initialization. Now, main simply calls three vl.c functions which
> handle the guest initialization, main loop and cleanup.
>
> Signed-off-by: Alexander Bulekov <address@hidden>
> ---
> Makefile | 1 +
> Makefile.objs | 2 ++
> Makefile.target | 2 +-
> include/sysemu/sysemu.h | 4 ++++
> main.c | 53 +++++++++++++++++++++++++++++++++++++++++
> vl.c | 36 +++++++---------------------
> 6 files changed, 70 insertions(+), 28 deletions(-)
> create mode 100644 main.c
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [PATCH v8 00/21] Add virtual device fuzzing support, Bulekov, Alexander, 2020/01/29
- [PATCH v8 02/21] module: check module wasn't already initialized, Bulekov, Alexander, 2020/01/29
- [PATCH v8 03/21] fuzz: add FUZZ_TARGET module type, Bulekov, Alexander, 2020/01/29
- [PATCH v8 04/21] qtest: add qtest_server_send abstraction, Bulekov, Alexander, 2020/01/29
- [PATCH v8 05/21] libqtest: add a layer of abstraction to send/recv, Bulekov, Alexander, 2020/01/29
- [PATCH v8 06/21] libqtest: make bufwrite rely on the TransportOps, Bulekov, Alexander, 2020/01/29
- [PATCH v8 07/21] qtest: add in-process incoming command handler, Bulekov, Alexander, 2020/01/29
- [PATCH v8 08/21] libqos: rename i2c_send and i2c_recv, Bulekov, Alexander, 2020/01/29