[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/29] accel/accel: Make TYPE_ACCEL abstract
From: |
Cornelia Huck |
Subject: |
Re: [PATCH v2 02/29] accel/accel: Make TYPE_ACCEL abstract |
Date: |
Thu, 30 Jan 2020 13:22:47 +0100 |
On Wed, 29 Jan 2020 22:23:18 +0100
Philippe Mathieu-Daudé <address@hidden> wrote:
> There is no generic acceleration, we have to use specific
> implementations. Make the base class abstract.
>
> Fixes: b14a0b7469f
Fixes: b14a0b7469fa ("accel: Use QOM classes for accel types")
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> accel/accel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/accel/accel.c b/accel/accel.c
> index cb555e3b06..a0169b4e69 100644
> --- a/accel/accel.c
> +++ b/accel/accel.c
> @@ -33,6 +33,7 @@
> static const TypeInfo accel_type = {
> .name = TYPE_ACCEL,
> .parent = TYPE_OBJECT,
> + .abstract = true,
> .class_size = sizeof(AccelClass),
> .instance_size = sizeof(AccelState),
> };
Reviewed-by: Cornelia Huck <address@hidden>
[PATCH v2 05/29] tests/acceptance: Restrict X86CPUModelAliases test to QEMU >= 4.1, Philippe Mathieu-Daudé, 2020/01/29
[PATCH v2 06/29] python/qemu: Add binutils::binary_get_arch(), Philippe Mathieu-Daudé, 2020/01/29