Re: [PATCH 0/4] target/ppc: Use probe_access

[Aleksandar Markovic]

00:51 Čet, 30.01.2020. Richard Henderson <address@hidden> је написао/ла:
>
> The first two address the performance regression noticed
> by Howard Spoelstra.  The last two are just something I
> noticed at the same time.
>

But, performance regression, according to Howard bisect analysis, happened because of the change in target-independant code, and the fix presented here is in target-specific code. This defies basic logic and deserves clear and detailed explanation.

My additional concern, of course, is: Are other targets exposed to performance degradation, and why?

Thanks,
Aleksandar

>
> r~
>
>
> Richard Henderson (4):
>   target/ppc: Use probe_access for LSW, STSW
>   target/ppc: Use probe_access for LMW, STMW
>   target/ppc: Remove redundant mask in DCBZ
>   target/ppc: Use probe_write for DCBZ
>
>  target/ppc/mem_helper.c | 197 +++++++++++++++++++++++++++++++++-------
>  1 file changed, 162 insertions(+), 35 deletions(-)
>
> --
> 2.20.1
>
>