Re: [PATCH 119/142] Aaaaallelujah!

[Marc-André Lureau]

Hi

On Wed, Jan 29, 2020 at 2:38 PM Aleksandar Markovic
<address@hidden> wrote:
>
> On Wed, Jan 29, 2020 at 1:26 PM Thomas Huth <address@hidden> wrote:
> >
> > On 28/01/2020 18.53, Paolo Bonzini wrote:
> > > From: Marc-André Lureau <address@hidden>
> > >
> > > Signed-off-by: Marc-André Lureau <address@hidden>
> > > ---
> >
> > Well, even for an RFC series, you could choose a better patch subject.
> > And please add a short description what this patch is all about.
> >
>
> Speaking seriously, I agree with Thomas absolutely 100%, but in case
> this patch is merged as is, I suggest that we establish "QEMU award
> for the most original patch subject 2020", and nominate this patch for
> it. ;) It would have had tremendous chances to be a winner. :)
>

fwiw, I originally wrote that patch subject, and pushed to my meson-poc branch.

It was quite an achievement to get meson to build all qemu binaries,
and seeing the light!

Later, Paolo took the branch over, and I didn't think he would just
publish it as is. But at least, it is consistent with the PoC status,
and you noticed it :)

The subject should be changed to something like: "meson: build qemu
executables", and the comment should at least mention that qemu
binaries are now located under $top_builddir instead of
$top_builddir/$arch-{softmmu,linux-user,..} (+1 from me, the subdir
was mostly there because of the complex recursive build system)

-- 
Marc-André Lureau