Re: [PATCH] git: Make submodule check only needed modules

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH] git: Make submodule check only needed modules
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
2f5847c git: Make submodule check only needed modules

=== OUTPUT BEGIN ===
ERROR: code indent should never use tabs
#28: FILE: scripts/git-submodule.sh:63:
+^ICURSTATUS=$($GIT submodule status $module)$

ERROR: code indent should never use tabs
#29: FILE: scripts/git-submodule.sh:64:
+^IOLDSTATUS=$(cat $substat | grep $module)$

ERROR: code indent should never use tabs
#30: FILE: scripts/git-submodule.sh:65:
+^Iif test "$CURSTATUS" != "$OLDSTATUS"; then$

ERROR: code indent should never use tabs
#31: FILE: scripts/git-submodule.sh:66:
+^I    exit 1$

ERROR: code indent should never use tabs
#32: FILE: scripts/git-submodule.sh:67:
+^Ifi$

total: 5 errors, 0 warnings, 18 lines checked

Commit 2f5847c70590 (git: Make submodule check only needed modules) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden