Re: [PATCH 01/13] qcrypto: add generic infrastructure for crypto options amendment

[Daniel P . Berrangé]

On Tue, Jan 14, 2020 at 09:33:38PM +0200, Maxim Levitsky wrote:
> This will be used first to implement luks keyslot management.
> 
> block_crypto_amend_opts_init will be used to convert
> qemu-img cmdline to QCryptoBlockAmendOptions
> 
> Signed-off-by: Maxim Levitsky <address@hidden>
> ---
>  block/crypto.c         | 17 +++++++++++++++++
>  block/crypto.h         |  3 +++
>  crypto/block.c         | 31 +++++++++++++++++++++++++++++++
>  crypto/blockpriv.h     |  8 ++++++++
>  include/crypto/block.h | 22 ++++++++++++++++++++++
>  qapi/crypto.json       | 16 ++++++++++++++++
>  6 files changed, 97 insertions(+)

Reviewed-by: Daniel P. Berrangé <address@hidden>


> diff --git a/qapi/crypto.json b/qapi/crypto.json
> index b2a4cff683..9faebd03d4 100644
> --- a/qapi/crypto.json
> +++ b/qapi/crypto.json
> @@ -309,3 +309,19 @@
>    'base': 'QCryptoBlockInfoBase',
>    'discriminator': 'format',
>    'data': { 'luks': 'QCryptoBlockInfoLUKS' } }
> +
> +
> +
> +##
> +# @QCryptoBlockAmendOptions:
> +#
> +# The options that are available for all encryption formats
> +# when initializing a new volume

minor point, the comment needs updating

> +#
> +# Since: 5.0
> +##
> +{ 'union': 'QCryptoBlockAmendOptions',
> +  'base': 'QCryptoBlockOptionsBase',
> +  'discriminator': 'format',
> +  'data': {
> +            } }

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|