Re: [PATCH v3 06/18] hw/core: Add core complex id in X86CPU topology

[Eric Blake]

On 12/3/19 6:37 PM, Babu Moger wrote:
> Introduce last level cache id(llc_id) in x86CPU topology.  This information is
> required to build the topology in EPIC mode.
>
> Signed-off-by: Babu Moger <address@hidden>
> ---

> +++ b/qapi/machine.json
> @@ -646,9 +646,11 @@
>   # @node-id: NUMA node ID the CPU belongs to
>   # @socket-id: socket number within node/board the CPU belongs to
>   # @die-id: die number within node/board the CPU belongs to (Since 4.1)
> -# @core-id: core number within die the CPU belongs to# @thread-id: thread 
> number within core the CPU belongs to
> +# @llc-id: last level cache number within node/board the CPU belongs to (Since 
> 4.2)

s/4.2/5.0/

> +# @core-id: core number within die the CPU belongs to
> +# @thread-id: thread number within core the CPU belongs to
>   #
> -# Note: currently there are 5 properties that could be present
> +# Note: currently there are 6 properties that could be present
>   # but management should be prepared to pass through other
>   # properties with device_add command to allow for future
>   # interface extension. This also requires the filed names to be kept in
> @@ -660,6 +662,7 @@
>     'data': { '*node-id': 'int',
>               '*socket-id': 'int',
>               '*die-id': 'int',
> +            '*llc-id': 'int',
>               '*core-id': 'int',
>               '*thread-id': 'int'
>     }
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org