Re: [PULL v3 00/11] target/hppa patch queue

[Peter Maydell]

On Fri, 24 Jan 2020 at 23:20, Richard Henderson
<address@hidden> wrote:
>
> Version 3 fixes printf formatting errors, and some indentation
> errors, in artist.c, lasips2.c, and i82596.c.
>
>
> r~
>
>
> The following changes since commit ba2ed84fe6a78f64b2da441750fc6e925d94106a:
>
>   Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-5.0-sf1' 
> into staging (2020-01-24 12:34:04 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/rth7680/qemu.git tags/pull-pa-20200124
>
> for you to fetch changes up to 5b33eecce852658121b1190fee466f01a69e1910:
>
>   target/hppa: Allow, but diagnose, LDCW aligned only mod 4 (2020-01-24 
> 14:35:58 -0800)
>
> ----------------------------------------------------------------
> Improve LASI emulation
> Add Artist graphics
> Fix main memory allocation
> Improve LDCW emulation wrt real hw

This fails to compile -- I suspect your pullreq needs updating
to account for something in Paolo's most recent applied pull:

/home/petmay01/qemu-for-merges/hw/net/lasi_i82596.c: In function
'lasi_82596_class_init':
/home/petmay01/qemu-for-merges/hw/net/lasi_i82596.c:171:7: error:
'DeviceClass {aka struct DeviceClass}' has no member named 'props'
     dc->props = lasi_82596_properties;
       ^

(and similar in hw/display/artist.c)

Looks like these should now be
     device_class_set_props(dc, lasi_82596_properties);

thanks
-- PMM