Re: [PATCH 0/9] more audio fixes and improvements

[Mark Cave-Ayland]

On 23/01/2020 07:41, Volker Rümelin wrote:

> The first two patches "audio: fix audio_generic_write" and
> "audio: fix audio_generic_read" are only compile tested. The
> code is only reachable from the DirectSound backend with the
> mixing-engine off. I don't know if it is reachable at all.
> I can't test because I don't have a Windows computer.
> 
> Volker Rümelin (9):
>   audio: fix audio_generic_write
>   audio: fix audio_generic_read
>   paaudio: remove unused variables
>   audio: prevent SIGSEGV in AUD_get_buffer_size_out
>   audio: fix bug 1858488
>   ossaudio: prevent SIGSEGV in oss_enable_out
>   ossaudio: prevent SIGPFE in oss_write
>   ossaudio: disable poll mode can't be reached
>   audio: audio_generic_get_buffer_in should honor *size
> 
>  audio/alsaaudio.c |  1 +
>  audio/audio.c     | 77 
> ++++++++++++++++++++++++++-----------------------------
>  audio/audio_int.h |  4 +--
>  audio/coreaudio.c |  7 +++--
>  audio/noaudio.c   |  1 +
>  audio/ossaudio.c  | 28 ++++++++++++--------
>  audio/paaudio.c   |  6 ++---
>  audio/sdlaudio.c  |  7 +++--
>  audio/wavaudio.c  |  1 +
>  9 files changed, 71 insertions(+), 61 deletions(-)

Thanks for your patches! I've had reports from some of the PPC emulation guys 
that
the switch to the new audio API broke the coreaudio backend on Macs (see
https://bugs.launchpad.net/qemu/+bug/1859916) and I've pointed them towards this
patchset, but sadly it still doesn't appear to fix the issue.

Have you seen any issues with the coreaudio backend during your testing?


ATB,

Mark.