Re: [PATCH v3 20/21] configure: Enable test and libs for zstd

[Dr. David Alan Gilbert]

* Juan Quintela (address@hidden) wrote:
> Signed-off-by: Juan Quintela <address@hidden>

Reviewed-by: Dr. David Alan Gilbert <address@hidden>

> ---
>  configure | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/configure b/configure
> index 557e4382ea..56ddfd7f8a 100755
> --- a/configure
> +++ b/configure
> @@ -448,6 +448,7 @@ lzo=""
>  snappy=""
>  bzip2=""
>  lzfse=""
> +zstd=""
>  guest_agent=""
>  guest_agent_with_vss="no"
>  guest_agent_ntddscsi="no"
> @@ -1343,6 +1344,10 @@ for opt do
>    ;;
>    --disable-lzfse) lzfse="no"
>    ;;
> +  --disable-zstd) zstd="no"
> +  ;;
> +  --enable-zstd) zstd="yes"
> +  ;;
>    --enable-guest-agent) guest_agent="yes"
>    ;;
>    --disable-guest-agent) guest_agent="no"
> @@ -1795,6 +1800,8 @@ disabled with --disable-FEATURE, default is enabled if 
> available:
>                    (for reading bzip2-compressed dmg images)
>    lzfse           support of lzfse compression library
>                    (for reading lzfse-compressed dmg images)
> +  zstd            support for zstd compression library
> +                  (for migration compression)
>    seccomp         seccomp support
>    coroutine-pool  coroutine freelist (better performance)
>    glusterfs       GlusterFS backend
> @@ -2408,6 +2415,24 @@ EOF
>      fi
>  fi
>  
> +##########################################
> +# zstd check
> +
> +if test "$zstd" != "no" ; then
> +    if $pkg_config --exist libzstd ; then
> +        zstd_cflags="$($pkg_config --cflags libzstd)"
> +        zstd_libs="$($pkg_config --libs libzstd)"
> +        LIBS="$zstd_libs $LIBS"
> +        QEMU_CFLAGS="$QEMU_CFLAGS $zstd_cflags"
> +        zstd="yes"
> +    else
> +        if test "$zstd" = "yes" ; then
> +            feature_not_found "libzstd" "Install libzstd devel"
> +        fi
> +        zstd="no"
> +    fi
> +fi
> +
>  ##########################################
>  # libseccomp check
>  
> @@ -6555,6 +6580,7 @@ echo "lzo support       $lzo"
>  echo "snappy support    $snappy"
>  echo "bzip2 support     $bzip2"
>  echo "lzfse support     $lzfse"
> +echo "zstd support      $zstd"
>  echo "NUMA host support $numa"
>  echo "libxml2           $libxml2"
>  echo "tcmalloc support  $tcmalloc"
> @@ -7114,6 +7140,10 @@ if test "$lzfse" = "yes" ; then
>    echo "LZFSE_LIBS=-llzfse" >> $config_host_mak
>  fi
>  
> +if test "$zstd" = "yes" ; then
> +  echo "CONFIG_ZSTD=y" >> $config_host_mak
> +fi
> +
>  if test "$libiscsi" = "yes" ; then
>    echo "CONFIG_LIBISCSI=m" >> $config_host_mak
>    echo "LIBISCSI_CFLAGS=$libiscsi_cflags" >> $config_host_mak
> -- 
> 2.24.1
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK