Re: [PATCH v3 09/21] migration: Add multifd-compress parameter

[Eric Blake]

On 1/23/20 5:58 AM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>
> ---
> Rename it to NONE
> Fix typos (dave)
> We don't need to chek values returned by visit_type_MultifdCompress (markus)
> Fix yet more typos (wei)
> ---
>   hw/core/qdev-properties.c    | 13 +++++++++++++

> +++ b/qapi/migration.json
> @@ -488,6 +488,19 @@
>   ##
>   { 'command': 'query-migrate-capabilities', 'returns':   
> ['MigrationCapabilityStatus']}
>   
> +##
> +# @MultifdCompress:
> +#
> +# An enumeration of multifd compression.
> +#
> +# @none: no compression.
> +#
> +# Since: 4.1

5.0, now

> +#
> +##
> +{ 'enum': 'MultifdCompress',
> +  'data': [ 'none' ] }
> +
>   ##
>   # @MigrationParameter:
>   #
> @@ -586,6 +599,9 @@
>   # @max-cpu-throttle: maximum cpu throttle percentage.
>   #                    Defaults to 99. (Since 3.1)
>   #
> +# @multifd-compress: Which compression method to use.
> +#                    Defaults to none. (Since 5.0)
> +#
>   # Since: 2.4
>   ##
>   { 'enum': 'MigrationParameter',
> @@ -598,7 +614,7 @@
>              'downtime-limit', 'x-checkpoint-delay', 'block-incremental',
>              'multifd-channels',
>              'xbzrle-cache-size', 'max-postcopy-bandwidth',
> -           'max-cpu-throttle' ] }
> +           'max-cpu-throttle', 'multifd-compress' ] }
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org