Re: [PULL 2/4] q800: add a block backend to the PRAM

[Peter Maydell]

On Tue, 7 Jan 2020 at 14:40, Laurent Vivier <address@hidden> wrote:
>
> This allows to save and restore the content of the PRAM.
> It may be useful if we want to check the configuration or to change it.
>
> The backend is added using mtd interface, for instance:
>
>     ... -drive file=pram.img,format=raw,if=mtd ...
>
> where pram.img is the file where the data will be stored, its size must
> be 256 bytes.
>
> Signed-off-by: Laurent Vivier <address@hidden>
> Message-Id: <address@hidden>
> +static void pram_update(MacVIAState *m)
> +{
> +    if (m->blk) {
> +        blk_pwrite(m->blk, 0, m->mos6522_via1.PRAM,
> +                   sizeof(m->mos6522_via1.PRAM), 0);
> +    }
> +}

Hi -- Coverity warns (CID 1412799) that this isn't checking
the return value from blk_pwrite().

thanks
-- PMM