Re: [PATCH 2/5] docs/sphinx: Add new hxtool Sphinx extension

[Peter Maydell]

On Tue, 21 Jan 2020 at 22:22, Peter Maydell <address@hidden> wrote:
> I suspect this is an incompatibility (or possibly just a
> dropped back-compatibility I was accidentally relying on)
> between Sphinx 1.7 and 1.8. (I tested with a 1.6 and a 1.7.)
>
> It looks like ExtensionError is now in sphinx.errors, so if you
> change
> +from sphinx.application import ExtensionError
>
> to "from sphinx.errors import ExtensionError" does that help?
>
> If so then I'll test later this week whether that works also
> for 1.7/1.6 or if we need to do some version-specific stuff.

This does indeed work for older Sphinx too, and it looks like
it's been the intended way to import ExtensionError for a
long time -- I guess it was just an accident of implementation
that importing from sphinx.application worked too.

thanks
-- PMM