Re: [PATCH REPOST v3 00/80] refactor main RAM allocation to use hostmem backend

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [PATCH REPOST v3 00/80] refactor main RAM allocation to use hostmem 
backend

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
28f0d42 tests:numa-test: use explicit memdev to specify node RAM
64e4393 tests:numa-test: make top level args dynamic and g_autofree(cli) 
cleanups
e6ea9bb hostmem: fix strict bind policy
339ae3c hostmem: introduce "prealloc-threads" property
a0a8b7f make mem_path local variable
cac7077 exec: drop bogus mem_path from qemu_ram_alloc_from_fd()
937af3d exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()
294588b remove no longer used memory_region_allocate_system_memory()
6a13317 sparc/niagara: use memdev for RAM
6b50ac9 sparc/sun4m: use memdev for RAM
6c88353 sparc/leon3: use memdev for RAM
c35345c ppc/virtex_ml507: use memdev for RAM
2b9aeb4 ppc/virtex_ml507: remove unused arguments
7f5e309 ppc/spapr: use memdev for RAM
d5ec039 ppc/prep: use memdev for RAM
4f02b90 ppc/{ppc440_bamboo, sam460ex}: use memdev for RAM
d02eb66 ppc/{ppc440_bamboo, sam460ex}: drop RAM size fixup
dd10982 ppc/ppc405_boards: use memdev for RAM
9741a0e ppc/ppc405_boards: add RAM size checks
fe790ac ppc/pnv: use memdev for RAM
3bec0ee ppc/mac_oldworld: use memdev for RAM
46e6217 ppc/mac_newworld: use memdev for RAM
281b13d ppc/e500: use memdev for RAM
8f31839 ppc/e500: drop RAM size fixup
06ffc73 mips/mips_r4k: use memdev for RAM
6c48078 mips/mips_mipssim: use memdev for RAM
74f382e mips/mips_malta: use memdev for RAM
49962be mips/mips_jazz: use memdev for RAM
b4e5189 mips/mips_fulong2e: use memdev for RAM
f7ef86f mips/mips_fulong2e: drop RAM size fixup
2349c09 mips/boston-cube: use memdev for RAM
288b0f9 m68k/next-cube: use memdev for RAM
d664fda m68k/mcf5208: use memdev for RAM
0ed8640 m68k/an5206: use memdev for RAM
2bafeaa lm32/milkymist: use memdev for RAM
5d13e10 lm32/lm32_boards: use memdev for RAM
1d97c07 x86/pc: use memdev for RAM
0628c4d x86/microvm: use memdev for RAM
f420b0e hppa: use memdev for RAM
a2a5383 hw/hppa/machine: Map the PDC memory region with higher priority
ce86cda hw/hppa/machine: Restrict the total memory size to 3GB
f451860 hw/hppa/machine: Correctly check the firmware is in PDC range
1220207 cris/axis_dev88: use memdev for RAM
0bf39f2 null-machine: use memdev for RAM
21613ae s390x/s390-virtio-ccw: use memdev for RAM
3641332 arm/xlnx-zcu102: use memdev for RAM
478a2a9 arm/xlnx-versal-virt: use memdev for RAM
07e35dd arm/xilinx_zynq: use memdev for RAM
ec3ff8e arm/xilinx_zynq: drop RAM size fixup
c73467d arm/virt: use memdev for RAM
a03708e arm/vexpress: use memdev for RAM
9dfd635 arm/versatilepb: use memdev for RAM
6b6397a arm/sbsa-ref: use memdev for RAM
10babd5 arm/sabrelite: use memdev for RAM
33a4e2b arm/raspi: use memdev for RAM
85cd733 arm/palm: use memdev for RAM
e587591 arm/omap_sx1: use memdev for RAM
44b7506 arm/nseries: use memdev for RAM
310bbb2 arm/musicpal: use memdev for RAM
cc5a043 arm/mps2: use memdev for RAM
e032a25 arm/mps2-tz: use memdev for RAM
0abbf17 arm/mcimx7d-sabre: use memdev for RAM
a44bded arm/mcimx6ul-evk: use memdev for RAM
395bc05 arm/kzm: use memdev for RAM
90a7cd2 arm/kzm: drop RAM size fixup
ca13b69 arm/integratorcp: use memdev for RAM
0893e7d arm/imx25_pdk: use memdev for RAM
021caf5 arm/imx25_pdk: drop RAM size fixup
af2dbf9 arm/highbank: use memdev for RAM
6e9dc93 arm/digic_boards: use memdev for RAM
64313e8 arm/cubieboard: use memdev for RAM
425d057 arm/collie: use memdev for RAM
73e2bc8 arm/aspeed: use memdev for RAM
6de64f3 arm/aspeed: actually check RAM size
954e0ec alpha:dp264: use memdev for RAM
34f13c1 initialize MachineState::ram in NUMA case
fdfae56 machine: introduce convenience MachineState::ram
065fc14 machine: alias -mem-path and -mem-prealloc into memory-foo backend
76900f9 machine: introduce memory-backend property
6a49dc0 numa: remove deprecated -mem-path fallback to anonymous RAM

=== OUTPUT BEGIN ===
1/80 Checking commit 6a49dc0538bc (numa: remove deprecated -mem-path fallback 
to anonymous RAM)
2/80 Checking commit 76900f97f62a (machine: introduce memory-backend property)
3/80 Checking commit 065fc1476423 (machine: alias -mem-path and -mem-prealloc 
into memory-foo backend)
4/80 Checking commit fdfae5645ca1 (machine: introduce convenience 
MachineState::ram)
5/80 Checking commit 34f13c129a81 (initialize MachineState::ram in NUMA case)
6/80 Checking commit 954e0ec8737b (alpha:dp264: use memdev for RAM)
ERROR: spaces required around that '*' (ctx:WxV)
#30: FILE: hw/alpha/alpha_sys.h:14:
+PCIBus *typhoon_init(MemoryRegion *, ISABus **, qemu_irq *, AlphaCPU *[4],
                                                                      ^

total: 1 errors, 0 warnings, 49 lines checked

Patch 6/80 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/80 Checking commit 6de64f38ddf7 (arm/aspeed: actually check RAM size)
8/80 Checking commit 73e2bc8bb37e (arm/aspeed: use memdev for RAM)
9/80 Checking commit 425d057fe70e (arm/collie: use memdev for RAM)
10/80 Checking commit 64313e86133a (arm/cubieboard: use memdev for RAM)
11/80 Checking commit 6e9dc93c1ae2 (arm/digic_boards: use memdev for RAM)
12/80 Checking commit af2dbf980370 (arm/highbank: use memdev for RAM)
13/80 Checking commit 021caf507b43 (arm/imx25_pdk: drop RAM size fixup)
14/80 Checking commit 0893e7d219c7 (arm/imx25_pdk: use memdev for RAM)
15/80 Checking commit ca13b699384c (arm/integratorcp: use memdev for RAM)
16/80 Checking commit 90a7cd27125c (arm/kzm: drop RAM size fixup)
17/80 Checking commit 395bc059e5e6 (arm/kzm: use memdev for RAM)
18/80 Checking commit a44bded9b399 (arm/mcimx6ul-evk: use memdev for RAM)
19/80 Checking commit 0abbf178464e (arm/mcimx7d-sabre: use memdev for RAM)
20/80 Checking commit e032a25b1bdf (arm/mps2-tz: use memdev for RAM)
21/80 Checking commit cc5a04303320 (arm/mps2: use memdev for RAM)
22/80 Checking commit 310bbb26a5d0 (arm/musicpal: use memdev for RAM)
23/80 Checking commit 44b7506173d1 (arm/nseries: use memdev for RAM)
24/80 Checking commit e5875912377a (arm/omap_sx1: use memdev for RAM)
25/80 Checking commit 85cd73342f55 (arm/palm: use memdev for RAM)
26/80 Checking commit 33a4e2b7e025 (arm/raspi: use memdev for RAM)
27/80 Checking commit 10babd50e8f7 (arm/sabrelite: use memdev for RAM)
28/80 Checking commit 6b6397ae93b6 (arm/sbsa-ref: use memdev for RAM)
29/80 Checking commit 9dfd635f4a05 (arm/versatilepb: use memdev for RAM)
30/80 Checking commit a03708e51b2d (arm/vexpress: use memdev for RAM)
31/80 Checking commit c73467dcc7bd (arm/virt: use memdev for RAM)
32/80 Checking commit ec3ff8eaf9c7 (arm/xilinx_zynq: drop RAM size fixup)
33/80 Checking commit 07e35dd85c30 (arm/xilinx_zynq: use memdev for RAM)
34/80 Checking commit 478a2a976000 (arm/xlnx-versal-virt: use memdev for RAM)
35/80 Checking commit 364133212cca (arm/xlnx-zcu102: use memdev for RAM)
36/80 Checking commit 21613ae37fe5 (s390x/s390-virtio-ccw: use memdev for RAM)
37/80 Checking commit 0bf39f2f5bfd (null-machine: use memdev for RAM)
38/80 Checking commit 1220207531bd (cris/axis_dev88: use memdev for RAM)
39/80 Checking commit f45186045981 (hw/hppa/machine: Correctly check the 
firmware is in PDC range)
40/80 Checking commit ce86cda1a8e7 (hw/hppa/machine: Restrict the total memory 
size to 3GB)
41/80 Checking commit a2a538392cf6 (hw/hppa/machine: Map the PDC memory region 
with higher priority)
42/80 Checking commit f420b0e2cd93 (hppa: use memdev for RAM)
43/80 Checking commit 0628c4d5d8be (x86/microvm: use memdev for RAM)
44/80 Checking commit 1d97c07c047f (x86/pc: use memdev for RAM)
45/80 Checking commit 5d13e105726d (lm32/lm32_boards: use memdev for RAM)
46/80 Checking commit 2bafeaab1467 (lm32/milkymist: use memdev for RAM)
47/80 Checking commit 0ed8640372a0 (m68k/an5206: use memdev for RAM)
48/80 Checking commit d664fdabf784 (m68k/mcf5208: use memdev for RAM)
49/80 Checking commit 288b0f9f7c1a (m68k/next-cube: use memdev for RAM)
50/80 Checking commit 2349c09ed98b (mips/boston-cube: use memdev for RAM)
51/80 Checking commit f7ef86f11f0b (mips/mips_fulong2e: drop RAM size fixup)
52/80 Checking commit b4e5189ba317 (mips/mips_fulong2e: use memdev for RAM)
53/80 Checking commit 49962bea6cb5 (mips/mips_jazz: use memdev for RAM)
54/80 Checking commit 74f382e62b3c (mips/mips_malta: use memdev for RAM)
55/80 Checking commit 6c48078f9a68 (mips/mips_mipssim: use memdev for RAM)
56/80 Checking commit 06ffc734cd43 (mips/mips_r4k: use memdev for RAM)
57/80 Checking commit 8f3183989d32 (ppc/e500: drop RAM size fixup)
58/80 Checking commit 281b13dcac57 (ppc/e500: use memdev for RAM)
59/80 Checking commit 46e62170c054 (ppc/mac_newworld: use memdev for RAM)
60/80 Checking commit 3bec0ee0a72c (ppc/mac_oldworld: use memdev for RAM)
61/80 Checking commit fe790ac8de76 (ppc/pnv: use memdev for RAM)
62/80 Checking commit 9741a0e38c44 (ppc/ppc405_boards: add RAM size checks)
63/80 Checking commit dd1098217df9 (ppc/ppc405_boards: use memdev for RAM)
64/80 Checking commit d02eb66b089e (ppc/{ppc440_bamboo, sam460ex}: drop RAM 
size fixup)
65/80 Checking commit 4f02b90b6cec (ppc/{ppc440_bamboo, sam460ex}: use memdev 
for RAM)
WARNING: Block comments use a leading /* on a separate line
#48: FILE: hw/ppc/ppc4xx_devs.c:669:
+/* Split RAM between SDRAM banks.

total: 0 errors, 1 warnings, 103 lines checked

Patch 65/80 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
66/80 Checking commit d5ec039191e8 (ppc/prep: use memdev for RAM)
67/80 Checking commit 7f5e309237cf (ppc/spapr: use memdev for RAM)
68/80 Checking commit 2b9aeb4d5e28 (ppc/virtex_ml507: remove unused arguments)
69/80 Checking commit c35345cc9c8e (ppc/virtex_ml507: use memdev for RAM)
70/80 Checking commit 6c883537133c (sparc/leon3: use memdev for RAM)
71/80 Checking commit 6b50ac9a623d (sparc/sun4m: use memdev for RAM)
72/80 Checking commit 6a13317c51a2 (sparc/niagara: use memdev for RAM)
73/80 Checking commit 294588be8a80 (remove no longer used 
memory_region_allocate_system_memory())
74/80 Checking commit 937af3df4f2d (exec: cleanup 
qemu_minrampagesize()/qemu_maxrampagesize())
75/80 Checking commit cac70772ccef (exec: drop bogus mem_path from 
qemu_ram_alloc_from_fd())
76/80 Checking commit a0a8b7fc4f32 (make mem_path local variable)
77/80 Checking commit 339ae3c25248 (hostmem: introduce "prealloc-threads" 
property)
78/80 Checking commit e6ea9bb4c870 (hostmem: fix strict bind policy)
79/80 Checking commit 64e4393761e9 (tests:numa-test: make top level args 
dynamic and g_autofree(cli) cleanups)
80/80 Checking commit 28f0d4235892 (tests:numa-test: use explicit memdev to 
specify node RAM)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden