[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH REPOST v3 39/80] hw/hppa/machine: Correctly check the firmware is
From: |
Igor Mammedov |
Subject: |
[PATCH REPOST v3 39/80] hw/hppa/machine: Correctly check the firmware is in PDC range |
Date: |
Thu, 23 Jan 2020 12:38:04 +0100 |
From: Philippe Mathieu-Daudé <address@hidden>
The firmware has to reside in the PDC range. If the Elf file
expects to load it below FIRMWARE_START, it is incorrect,
regardless the RAM size.
Acked-by: Helge Deller <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Igor Mammedov <address@hidden>
---
hw/hppa/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c
index 5d0de26..6775d87 100644
--- a/hw/hppa/machine.c
+++ b/hw/hppa/machine.c
@@ -155,7 +155,7 @@ static void machine_hppa_init(MachineState *machine)
qemu_log_mask(CPU_LOG_PAGE, "Firmware loaded at 0x%08" PRIx64
"-0x%08" PRIx64 ", entry at 0x%08" PRIx64 ".\n",
firmware_low, firmware_high, firmware_entry);
- if (firmware_low < ram_size || firmware_high >= FIRMWARE_END) {
+ if (firmware_low < FIRMWARE_START || firmware_high >= FIRMWARE_END) {
error_report("Firmware overlaps with memory or IO space");
exit(1);
}
--
2.7.4
- [PATCH REPOST v3 34/80] arm/xlnx-versal-virt: use memdev for RAM, (continued)
- [PATCH REPOST v3 34/80] arm/xlnx-versal-virt: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 32/80] arm/xilinx_zynq: drop RAM size fixup, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 31/80] arm/virt: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 35/80] arm/xlnx-zcu102: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 33/80] arm/xilinx_zynq: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 37/80] null-machine: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 40/80] hw/hppa/machine: Restrict the total memory size to 3GB, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 41/80] hw/hppa/machine: Map the PDC memory region with higher priority, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 36/80] s390x/s390-virtio-ccw: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 38/80] cris/axis_dev88: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 39/80] hw/hppa/machine: Correctly check the firmware is in PDC range,
Igor Mammedov <=
- [PATCH REPOST v3 42/80] hppa: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 43/80] x86/microvm: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 44/80] x86/pc: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 47/80] m68k/an5206: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 46/80] lm32/milkymist: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 45/80] lm32/lm32_boards: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 48/80] m68k/mcf5208: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 50/80] mips/boston-cube: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 49/80] m68k/next-cube: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 51/80] mips/mips_fulong2e: drop RAM size fixup, Igor Mammedov, 2020/01/23