Re: [PATCH v2 066/109] vhost-user: Print unexpected slave message types

[Dr. David Alan Gilbert]

* Philippe Mathieu-Daudé (address@hidden) wrote:
> On 1/21/20 1:23 PM, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> > 
> > When we receive an unexpected message type on the slave fd, print
> > the type.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> > Reviewed-by: Daniel P. Berrangé <address@hidden>
> > ---
> >   hw/virtio/vhost-user.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> > index d27a10fcc6..9ec8c2a27c 100644
> > --- a/hw/virtio/vhost-user.c
> > +++ b/hw/virtio/vhost-user.c
> > @@ -1061,7 +1061,7 @@ static void slave_read(void *opaque)
> >                                                             fd[0]);
> >           break;
> >       default:
> > -        error_report("Received unexpected msg type.");
> > +        error_report("Received unexpected msg type. (%d)", hdr.request);
> 
> With either "Received unexpected msg type (%d)."
> or "Received unexpected msg type: %d." instead:

OK.

> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

Thanks.

> >           ret = -EINVAL;
> >       }
> > 
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK