Re: [PATCH v8 06/13] linux-user: Add support for read/clear RTC voltage low detector using ioctls

[Laurent Vivier]

Le 15/01/2020 à 20:36, Filip Bozuta a écrit :
> This patch implements functionalities of following ioctls:
> 
> RTC_VL_READ - Read voltage low detection information
> 
>     Read the voltage low for RTCs that support voltage low.
>     The third ioctl's' argument points to an int in which
>     the voltage low is returned.
> 
> RTC_VL_CLR - Clear voltage low information
> 
>     Clear the information about voltage low for RTCs that
>     support voltage low. The third ioctl(2) argument is
>     ignored.
> 
> Implementation notes:
> 
>     Since one ioctl has a pointer to 'int' as its third agrument,
>     and another ioctl has NULL as its third argument, their
>     implementation was straightforward.
> 
> Reviewed-by: Laurent Vivier <address@hidden>
> Signed-off-by: Filip Bozuta <address@hidden>
> ---
>  linux-user/ioctls.h       | 2 ++
>  linux-user/syscall_defs.h | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h
> index 0a4e3f1..1f1f3e6 100644
> --- a/linux-user/ioctls.h
> +++ b/linux-user/ioctls.h
> @@ -89,6 +89,8 @@
>       IOCTL(RTC_WKALM_SET, IOC_W, MK_PTR(MK_STRUCT(STRUCT_rtc_wkalrm)))
>       IOCTL(RTC_PLL_GET, IOC_R, MK_PTR(MK_STRUCT(STRUCT_rtc_pll_info)))
>       IOCTL(RTC_PLL_SET, IOC_W, MK_PTR(MK_STRUCT(STRUCT_rtc_pll_info)))
> +     IOCTL(RTC_VL_READ, IOC_R, MK_PTR(TYPE_INT))
> +     IOCTL(RTC_VL_CLR, 0, TYPE_NULL)
>  
>       IOCTL(BLKROSET, IOC_W, MK_PTR(TYPE_INT))
>       IOCTL(BLKROGET, IOC_R, MK_PTR(TYPE_INT))
> diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
> index 8370f41..af4f366 100644
> --- a/linux-user/syscall_defs.h
> +++ b/linux-user/syscall_defs.h
> @@ -796,6 +796,8 @@ struct target_rtc_pll_info {
>                                                 struct target_rtc_pll_info)
>  #define TARGET_RTC_PLL_SET          TARGET_IOW('p', 0x12,                    
>   \
>                                                 struct target_rtc_pll_info)
> +#define TARGET_RTC_VL_READ          TARGET_IOR('p', 0x13, int)
> +#define TARGET_RTC_VL_CLR           TARGET_IO('p', 0x14)
>  
>  #if defined(TARGET_ALPHA) || defined(TARGET_MIPS) || defined(TARGET_SH4) ||  
>   \
>         defined(TARGET_XTENSA)
> 

Applied to my linux-user branch.

Thanks,
Laurent