[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/misc/stm32f4xx_syscfg: Fix copy/paste error
|
From: |
Thomas Huth |
|
Subject: |
Re: [PATCH] hw/misc/stm32f4xx_syscfg: Fix copy/paste error |
|
Date: |
Wed, 22 Jan 2020 08:19:48 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 21/01/2020 22.38, Philippe Mathieu-Daudé wrote:
> Missed in 870c034da0b, hopefully reported by Coverity.
>
> Fixes: Coverity CID 1412793 (Incorrect expression)
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/misc/stm32f4xx_syscfg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/stm32f4xx_syscfg.c b/hw/misc/stm32f4xx_syscfg.c
> index dbcdca59f8..f960e4ea1e 100644
> --- a/hw/misc/stm32f4xx_syscfg.c
> +++ b/hw/misc/stm32f4xx_syscfg.c
> @@ -47,7 +47,7 @@ static void stm32f4xx_syscfg_set_irq(void *opaque, int irq,
> int level)
> STM32F4xxSyscfgState *s = opaque;
> int icrreg = irq / 4;
> int startbit = (irq & 3) * 4;
> - uint8_t config = config = irq / 16;
> + uint8_t config = irq / 16;
>
> trace_stm32f4xx_syscfg_set_irq(irq / 16, irq % 16, level);
>
>
Reviewed-by: Thomas Huth <address@hidden>